Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3.10-ism that crept in and test 3.9 in CI #52

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Jul 18, 2024

Fixes: #51

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added

Copy link

github-actions bot commented Jul 18, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
693 693 100% 99% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
chart_review/init.py 100% 🟢
chart_review/common.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 833e96b by action🐍

@mikix mikix force-pushed the mikix/3.9-fixes branch from 73aa178 to 7508610 Compare July 18, 2024 17:02
@mikix mikix changed the title Fix 3.9-ism that crept in and test 3.9 in CI Fix 3.10-ism that crept in and test 3.9 in CI Jul 18, 2024
@mikix mikix force-pushed the mikix/3.9-fixes branch 2 times, most recently from 2153614 to f5a85fd Compare July 18, 2024 17:03
@mikix mikix force-pushed the mikix/3.9-fixes branch from f5a85fd to 833e96b Compare July 18, 2024 17:05
Copy link

@dogversioning dogversioning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine if you want, but I like the 3.10 typings enough that I'm willing to drop 3.9.

@mikix
Copy link
Contributor Author

mikix commented Jul 18, 2024

Fine if you want, but I like the 3.10 typings enough that I'm willing to drop 3.9.

Since this is a general purpose app, I'd prefer to support as wide a set of active pythons as possible. We did just talk to someone today that was on python3.9

@mikix mikix merged commit 213ee5f into main Jul 18, 2024
5 checks passed
@mikix mikix deleted the mikix/3.9-fixes branch July 18, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No minimum python version listed, but 3.10 or above is required for | operator for union types.
2 participants