Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3.10-ism that crept in and test 3.9 in CI #52

Merged
merged 1 commit into from
Jul 18, 2024
+5 −5
Merged

Fix 3.10-ism that crept in and test 3.9 in CI #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
# don't go crazy with the Python versions as they eat up CI minutes
python-version: ["3.10"]
python-version: ["3.9", "3.10", "3.11", "3.12"]

steps:
- uses: actions/checkout@v4
Expand All @@ -26,6 +25,7 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: pip

- name: Install dependencies
run: |
Expand All @@ -38,7 +38,7 @@ jobs:

- name: Check coverage report
if: github.ref != 'refs/heads/main'
uses: orgoro/coverage@v3.1
uses: orgoro/coverage@v3.2
with:
coverageFile: coverage.xml
token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion chart_review/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
"""Chart Review public entry point"""

__version__ = "2.0.0"
__version__ = "2.0.1"
2 changes: 1 addition & 1 deletion chart_review/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def read_json(path: str) -> Union[dict, list[dict]]:
return json.load(f, strict=False)


def write_json(path: str, data: dict | list, indent: Optional[int] = 4) -> None:
def write_json(path: str, data: Union[dict, list], indent: Optional[int] = 4) -> None:
"""
Writes data to the given path, in json format
:param path: filesystem path
Expand Down