Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Fix warnings of all examples #5183

Merged
merged 10 commits into from
Jan 22, 2025

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Dec 29, 2024

My 🎁 to SOFA users πŸ‡¨πŸ‡½

Obviously, this might trigger regressions πŸ€·β€β™‚οΈ
πŸ‘‡ Some questions πŸ‘‡

  • [ObjectFactory] Class already registered in the ObjectFactory: CapsuleCollisionModel
  • Demos/skybox.scn : NOT working
  • Demos/SofaWasher.scn : transparence
  • SofaValidation not compiled (needed for examples/Component/SceneUtility/Monitor.scn, same SleepController + test_sleep)
  • MakeDataAlias is not working (examples/Component/SceneUtility/MakeDataAlias.scn + test)
  • @epernod : /data/Softwares/sofa/src/master/examples/Component/Topology/Container/Dynamic/IncisionTrianglesProcess.scn massive warnings : Two consecutives values are equal

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code pr: backport todo This PR will be backported into the release preceeding its milestone. labels Dec 29, 2024
@fredroy
Copy link
Contributor

fredroy commented Dec 30, 2024

[ci-build][with-all-tests]

@damienmarchal
Copy link
Contributor

Remove MakeDataAlias... it was introduce to avoid complains about removing the alias in core of Sofa. Now we agreed, we could drop it :)

@epernod
Copy link
Contributor

epernod commented Jan 10, 2025

@hugtalbot yes, this will be solved (hopefully) in a few incoming PR where I totally change the incision algorithm process.
For now I think you need to keep the warning for this scene.

@hugtalbot
Copy link
Contributor Author

hugtalbot commented Jan 19, 2025

OK, so far, the PR is therefore ready for review and then merge
@damienmarchal's changes will be done in a dedicated PR

@damienmarchal do you confirm that both MakeAliasComponent and MakeDataAliasComponent can be removed?

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 22, 2025
@epernod epernod merged commit b754512 into sofa-framework:master Jan 22, 2025
7 of 11 checks passed
@hugtalbot hugtalbot added this to the v25.06 milestone Jan 26, 2025
@hugtalbot hugtalbot removed the pr: backport todo This PR will be backported into the release preceeding its milestone. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants