[Topology.Container] Add new method computeSegmentTriangleIntersectionInPlane in TriangleSetGeometryAlgorithm #5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epernod
added
pr: status to review
|
I think some unit tests would be welcomed, especially for new things like these, introduced in "core" modules. |
bakpaul
approved these changes
Jan 20, 2025
| type::fixed_array<Vec3, 3> triP = { Vec3(c0[0], c0[1], c0[2]), Vec3(c1[0], c1[1], c1[2]), Vec3(c2[0], c2[1], c2[2]) }; | ||
|
|
||
| // Project A and B into triangle plan | ||
| Vec3 v_normal = (triP[2] - triP[0]).cross(triP[1] - triP[0]); |
There was a problem hiding this comment.
It changes nothing to the computation afterwards, but isn't this the opposite of the normal ?
hugtalbot
added
pr: status wip
epernod
force-pushed
the
inf_2025_01_triangleSegmentIntersection
branch
from
e4d76ca to
2daf7df
Compare
… test adding and removing triangles
…t TriangleSegmentIntersection inside same plane or with projection
epernod
added
pr: status to review
|
Tests have been added but in middle of others changes which have been suggested in PR #5246 |
|
[ci-build][with-all-tests] |
|
CI is failing @epernod |
This has been fixed in #5246 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: PR based on #5246
This method compute the intersection between a Triangle from the current topology and a Segment [AB] which will be projected in Triangle Frame. Using Segment-Segment intersection from
geometry::Edge::intersectionWithEdgeReturn true if there is an intersection otherwise false.
Will fill input variables
sofa::type::vector<EdgeID>& intersectedEdgesandsofa::type::vector<Real>& baryCoefswith the list of intersected edges (Id in global topology, not relative to the triangle) and the barycoef of the intersection relative to the first vertex of the edge. I.e coordinate of the intersection is: Edge[0] * barycoef + Edge[1] * (1-barycoef )This method will replace
computeSegmentTriangleIntersectionwhen all the work regarding new incision in triangle using TriangleSubvider is finished.By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if