[Bugfix] Fix import error in device_utils.py.
#16860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vvolam
reviewed
Feb 8, 2025
| @@ -18,6 +18,7 @@ | |||
| from tests.common.mellanox_data import is_mellanox_device | |||
| from tests.common.platform.reboot_timing_constants import SERVICE_PATTERNS, OTHER_PATTERNS, SAIREDIS_PATTERNS, \ | |||
| OFFSET_ITEMS, TIME_SPAN_ITEMS, REQUIRED_PATTERNS | |||
| from tests.platform_tests.api.conftest import start_platform_api_service # noqa F401 | |||
There was a problem hiding this comment.
Can we get rid of this flake error noqa? It is flowing down in all the code which does not make code clean.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@yutongzhang-microsoft Please backport the fix to 202411 branch as well, where #15605 changes are present. |
wangxin
approved these changes
Feb 10, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 4, 2025
What is the motivation for this PR? In PR sonic-net#15605, the platform_api_conn fixture was relocated to a common location. The fixture start_platform_api_service used by it is not imported in this script, which will casue error fixture 'start_platform_api_service' not found. This PR addresses the issue by moving fixture start_platform_api_service to a common place tests/conftest.py. How did you do it? This PR addresses the issue by moving fixture start_platform_api_service to a common place tests/conftest.py. How did you verify/test it? Test locally to run the test script test_reload_dpu.py. There is no such import error.
|
Cherry-pick PR to 202411: #17339 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Mar 5, 2025
What is the motivation for this PR? In PR #15605, the platform_api_conn fixture was relocated to a common location. The fixture start_platform_api_service used by it is not imported in this script, which will casue error fixture 'start_platform_api_service' not found. This PR addresses the issue by moving fixture start_platform_api_service to a common place tests/conftest.py. How did you do it? This PR addresses the issue by moving fixture start_platform_api_service to a common place tests/conftest.py. How did you verify/test it? Test locally to run the test script test_reload_dpu.py. There is no such import error.
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
In PR #15605, the
platform_api_connfixture was relocated to a common location. The fixturestart_platform_api_serviceused by it is not imported in this script, which will casue errorfixture 'start_platform_api_service' not found. This PR addresses the issue by moving fixturestart_platform_api_serviceto a common placetests/conftest.py.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In PR #15605, the
platform_api_connfixture was relocated to a common location. The fixturestart_platform_api_serviceused by it is not imported in this script, which will casue errorfixture 'start_platform_api_service' not found. This PR addresses the issue by moving fixturestart_platform_api_serviceto a common placetests/conftest.py.How did you do it?
This PR addresses the issue by moving fixture
start_platform_api_serviceto a common placetests/conftest.py.How did you verify/test it?
Test locally to run the test script
test_reload_dpu.py. There is no such import error.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation