Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix import error in device_utils.py. #16860

Merged
merged 2 commits into from
Feb 10, 2025
Merged

[Bugfix] Fix import error in device_utils.py. #16860

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
faf13ee
Fix import error
yutongzhang-microsoft Feb 8, 2025
a022949
bugfix
yutongzhang-microsoft Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/common/platform/device_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from tests.common.mellanox_data import is_mellanox_device
from tests.common.platform.reboot_timing_constants import SERVICE_PATTERNS, OTHER_PATTERNS, SAIREDIS_PATTERNS, \
OFFSET_ITEMS, TIME_SPAN_ITEMS, REQUIRED_PATTERNS
from tests.platform_tests.api.conftest import start_platform_api_service # noqa F401
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of this flake error noqa? It is flowing down in all the code which does not make code clean.


"""
Helper script for fanout switch operations
Expand Down Expand Up @@ -983,7 +984,7 @@ def advanceboot_neighbor_restore(duthosts, enum_rand_one_per_hwsku_frontend_host


@pytest.fixture(scope='function')
def platform_api_conn(duthosts, enum_rand_one_per_hwsku_hostname, start_platform_api_service):
def platform_api_conn(duthosts, enum_rand_one_per_hwsku_hostname, start_platform_api_service): # noqa F811
duthost = duthosts[enum_rand_one_per_hwsku_hostname]
dut_ip = duthost.mgmt_ip

Expand Down
Loading