Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync2: dbset: use single connection for each sync session #6446

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

sync2: fixup for temporary OrderedSet copies

9e585e5
Select commit
Loading
Failed to load commit list.
Open

sync2: dbset: use single connection for each sync session #6446

sync2: fixup for temporary OrderedSet copies
9e585e5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 18, 2024 in 1s

79.9% (-0.1%) compared to f711c61

View this Pull Request on Codecov

79.9% (-0.1%) compared to f711c61

Details

Codecov Report

Attention: Patch coverage is 72.30769% with 36 lines in your changes missing coverage. Please review.

Project coverage is 79.9%. Comparing base (f711c61) to head (9e585e5).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
sql/database.go 54.8% 10 Missing and 4 partials ⚠️
sync2/multipeer/split_sync.go 63.6% 7 Missing and 1 partial ⚠️
sync2/dbset/dbset.go 73.9% 5 Missing and 1 partial ⚠️
sync2/multipeer/multipeer.go 73.3% 4 Missing ⚠️
sync2/rangesync/dumbset.go 40.0% 3 Missing ⚠️
sync2/multipeer/setsyncbase.go 95.6% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           develop   #6446     +/-   ##
=========================================
- Coverage     79.9%   79.9%   -0.1%     
=========================================
  Files          352     352             
  Lines        46096   46148     +52     
=========================================
+ Hits         36865   36894     +29     
- Misses        7142    7162     +20     
- Partials      2089    2092      +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

View more details on Codecov