Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py311 #80

Open
wants to merge 95 commits into
base: main
Choose a base branch
from
Open

Py311 #80

wants to merge 95 commits into from

Conversation

scfleming
Copy link
Collaborator

Modernizes up to Python 3.12 as well as Python 3.11, despite the branch name.

jaymedina and others added 30 commits October 11, 2022 12:09
…a-under-curves, tremolo values based on std dev
…range; setting default lfo to min amp for ranges with 0 freq
…es for preview type = scan and ensemble, ensemble plays with diff pitches and the combined, scan plays with same pitch and no combined at the end, re-wrote OBAFGKM notebook so it fetches sample spectra from public Box links at STScI, no assumptions made about location on user's computer, still need to finish the BAFGKM stars, but both versions for O star work
@scfleming scfleming linked an issue Jan 31, 2025 that may be closed by this pull request
@scfleming scfleming requested a review from ceb8 January 31, 2025 20:41
@scfleming
Copy link
Collaborator Author

@ceb8 I had to fix some "at the very end" merge conflicts. I think I have done so correctly, and things seem to be passing. Although if possible it would be great to confirm further that things are working, especially regarding the case-sensitivity of columns when specifying time and value names. The intention is to be for them to work whether the column names are all lowercase or not.

@scfleming
Copy link
Collaborator Author

I did a quick test of use of column names with not-all-lowercase, on what should have been a fresh install, and it seemed to work.

@scfleming scfleming linked an issue Jan 31, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants