-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py311 #80
Merged
Py311 #80
Changes from all commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
81e589f
initial commit of spectra preview sonification
jaymedina e2bb7a5
.
jaymedina 9ed0116
major edit on sonify_preview function, defines amplitude based on are…
scfleming 8fa6db0
.
jaymedina 78e8805
connecting classes
jaymedina 2c01180
updating play() with layered pitches that are delayed at different times
jaymedina 4ef0c86
multiplying amplitude by factor to increase vol
jaymedina b982c88
some updates to duration and delay periods
jaymedina cb7bca3
Constraint added to keep tremolo values at or below 15
jaymedina 95f2af5
added some todo items to preview_play
jaymedina 3810d61
Adding a "tremolo factor" which will multiply all tremolo vals by 10
jaymedina 6bbcd07
modulating amplitudes with inverse log; playing notes separately;
jaymedina 792f6ce
snapshots notebook
jaymedina 15ae515
replacing std with the std error of a linear regression fit
jaymedina f9bdd12
normalizing amplitudes with the max amp for more comfortable hearing …
jaymedina 7d567fb
changing default lfo to 1.0
jaymedina 72d800b
minor changes
jaymedina 4f2e4cd
initial attempt at increasing amplitude for non-oscillating behavior.…
jaymedina 0a59077
adding verbose and plotting keyword args to sonify_preview
jaymedina 911703c
only left channel sounding bug fixed
srisund 55cfda4
Real spectra demo notebook added
srisund c41c9c0
WIP: flipped colors in plots to match wavelength order, added two mod…
scfleming 836f458
updating .gitignore with new generated directory miles_stellar_spectra
jaymedina b69b2f0
adding requests and notebook as dependencies of astronify. pinning re…
jaymedina 5bf6b63
intermediate checkin
scfleming b080e8f
after merge
scfleming 95f5d6e
removing thinkx, numpy 2.0 fix, updating versions of libraries used i…
scfleming c3c19ac
fixing documentation format error
scfleming f162357
adding new requireemnts in RTD yaml
scfleming 005732a
fixing RTD yaml
scfleming 0e831b1
fixing RTD yaml
scfleming 720747c
fixing RTD yaml
scfleming 97e001f
fixing RTD yaml
scfleming f4bdf96
fixing RTD yaml
scfleming 6fcf883
fixing RTD yaml
scfleming 2108c45
fixing RTD yaml
scfleming 345455a
fixing RTD yaml
scfleming d14897b
fixing RTD yaml
scfleming 25f6a4e
adding requirements file for RTD
scfleming 0f8c1c2
adding requirements file for RTD
scfleming 74da113
adding requirements file for RTD
scfleming aa268a8
adding requirements file for RTD
scfleming d3888f6
adding requirements file for RTD
scfleming 09d32aa
adding requirements file for RTD
scfleming 43a7585
adding requirements file for RTD
scfleming ad3d922
adding requirements file for RTD
scfleming 11ee493
building RTD using Python 3.11 since the package is only good up to t…
scfleming 7f33813
updated tox.ini file that works locally in Python 3.11 at least
scfleming ea4d968
adding helpful hints for problems installing pyo dependencies, fixed …
scfleming e81b16d
specifying <3.12 in setup.cfg, removing Python 3.12 from tox for what…
scfleming 00bca20
adding extra installation tips, fixes #74 and fixes #77
scfleming 5084ff8
Adds citation information and ASCL badge to top-level README
scfleming 0dae887
first attempt at updating CI
scfleming 777e885
first attempt at updating CI
scfleming 0b2ff1f
removing comments from yml
scfleming 4fa4da2
Adding hash for Action workflow and update if needed, from PR #78
scfleming ee52abc
fixing typos as found by contributor in #75
scfleming 95d6e33
updates to use dev wheels instead of source, from #73
scfleming 33f84e8
adding this branch to list to run CI on push
scfleming 8f8a7fd
fixing CI by specifying Python versions correctly
scfleming 6a5d26a
fixed imcompatible test of numpy 2.1.x with Python 3.9.x
scfleming 2a01451
pre-installing pyo dependencies with apt-get
scfleming e1938c7
removes unmaintained pytest-openfiles in favor of pytest -W argument,…
scfleming 1d48eed
fixing the allowed-failure tests by pre-installing the pyo dependencies
scfleming de4b53a
working on some code style fixes
scfleming 1569966
updates for code styling, marking style check to continue on error
scfleming 2731f24
undoing mistake in CI yml
scfleming 7dab1ed
removing lynting from flake8, start at switch to black
scfleming 2c097b3
removing the CI tests with oldest deps since they never find runners,…
scfleming ba18ab0
big round of black lynting
scfleming 2ad1da0
iterating on lynting
scfleming 4430c8d
more lynt iterating
scfleming d308938
lynting iteration
scfleming a79ef4a
lynting iteration
scfleming 0282c6f
lynting series.py
scfleming 0e1397f
lynting series.py
scfleming 87139b7
more lynting
scfleming c008d9a
lynt iterating
scfleming 00c0f72
another round of lynting
scfleming e39226e
almost last round of lynting
scfleming 1006608
last lynting
scfleming 79a6aa3
adding Pey-Lian as a contributing author
scfleming b4883e2
adding CODEOWNERS file so merges into main require approval from at l…
scfleming e589c78
splitting developer documentation from main doc, adding some links to…
scfleming 3800b43
trying to fix links
scfleming 34b37fb
trying to fix links
scfleming b359932
adding better tip of how to build docs locally with sphinx directly
scfleming 40a5b70
adding some work-in-progress dev steps, adding __version__, updating …
scfleming 89603bb
Preparing release 0.11
scfleming 70aa31a
Preparing release 0.11
scfleming f8bf669
Preparing release 0.11
scfleming 2e8bdf7
Merge branch 'main' into py311
scfleming 33edb99
fixing conflict merge issues
scfleming e81f6cf
fixing conflict merge issues
scfleming 0c96a8b
another round of fixing conflict merge issues
scfleming File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# This is a comment. | ||
# Each line is a file pattern followed by one or more owners. | ||
|
||
# These owners will be the default owners for everything in | ||
# the repo. Unless a later match takes precedence, | ||
# these owners will be requested for | ||
# review when someone opens a pull request. | ||
* @ceb8 @scfleming |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# To get started with Dependabot version updates, you'll need to specify which | ||
# package ecosystems to update and where the package manifests are located. | ||
# Please see the documentation for all configuration options: | ||
# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates | ||
|
||
version: 2 | ||
updates: | ||
- package-ecosystem: "github-actions" # See documentation for possible values | ||
directory: ".github/workflows" # Location of package manifests | ||
schedule: | ||
interval: "monthly" | ||
groups: | ||
actions: | ||
patterns: | ||
- "*" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
name: Lint | ||
|
||
on: [push, pull_request] | ||
|
||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: psf/black@stable |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,23 @@ | ||
version: 2 | ||
|
||
build: | ||
image: latest | ||
os: "ubuntu-24.04" | ||
tools: | ||
python: "3.11" | ||
apt_packages: | ||
- portaudio19-dev | ||
- libsndfile1-dev | ||
- libportmidi-dev | ||
- liblo-dev | ||
|
||
python: | ||
version: 3.7 | ||
install: | ||
- method: pip | ||
path: . | ||
extra_requirements: | ||
- docs | ||
- all | ||
- requirements: docs/requirements.txt | ||
|
||
formats: [] | ||
sphinx: | ||
configuration: docs/conf.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
cff-version: 1.1.0 | ||
message: "Please cite the following works when using this software: https://ui.adsabs.harvard.edu/abs/2024ascl.soft08005B" | ||
authors: | ||
- family-names: Brasseur | ||
given-names: C. E. | ||
- family-names: Fleming | ||
given-names: S. | ||
- family-names: Kotler | ||
given-names: J. | ||
- family-names: Meredith | ||
given-names: K. | ||
title: "Astronify: Astronomical data sonification" | ||
version: 0.11 | ||
date-released: 2025-01-31 | ||
identifiers: | ||
- type: "ascl-id" | ||
value: "2408.005" | ||
- type: "bibcode" | ||
value: "2024ascl.soft08005B" | ||
abstract: "Astronify contains tools for sonifying astronomical data, specifically data series. Data series sonification takes a data table and maps one column to time, and one column to pitch. This technique is commonly used to sonify light curves, where observation time is scaled to listening time and flux is mapped to pitch. While Astronify’s sonification uses the columns “time” and “flux” by default, any two columns can be supplied and a sonification created." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,104 @@ | ||
Developer Documentation | ||
----------------------- | ||
|
||
This documentation is intended for code maintainers and developers as a guide, especially when preparing to merge and release a new version of the code. | ||
|
||
Installation | ||
^^^^^^^^^^^^ | ||
|
||
.. code-block:: bash | ||
|
||
$ git clone https://github.com/spacetelescope/astronify.git | ||
$ cd astronify | ||
$ pip install . | ||
|
||
For active development, install in develop mode | ||
|
||
.. code-block:: bash | ||
|
||
$ pip install -e . | ||
|
||
|
||
Testing | ||
^^^^^^^ | ||
Testing is run with `tox <https://tox.readthedocs.io>`_ (``pip install tox``). | ||
Tests can be found in ``tests/`` sub-directories. | ||
|
||
.. code-block:: bash | ||
|
||
$ tox -e test | ||
|
||
Tests can also be run directly with pytest: | ||
|
||
.. code-block:: bash | ||
|
||
$ pip install -e .[test] | ||
$ pytest | ||
|
||
|
||
Documentation | ||
^^^^^^^^^^^^^ | ||
|
||
Documentation files are found in ``docs/``. | ||
|
||
We build the documentation with `tox <https://tox.readthedocs.io>`_ (``pip install tox``): | ||
|
||
.. code-block:: bash | ||
|
||
$ tox -e build_docs | ||
|
||
You can also build the documentation with Sphinx directly using: | ||
|
||
.. code-block:: bash | ||
|
||
$ cd docs | ||
$ sphinx-build -M html . _build/ | ||
|
||
The built docs will be in ``docs/_build/html/``, to view them go to ``file://</path/to/astronify/repo/>docs/_build/html/index.html`` in the browser of your choice. | ||
|
||
|
||
Release Protocol | ||
^^^^^^^^^^^^^^^^ | ||
|
||
TO-BE-FINALIZED | ||
|
||
- Update the ``ci_workflows.yml`` under ``.github/workflows/`` to | ||
remove any inactive branches and add your new development branch, | ||
under the ``push`` section towards the top of the file. | ||
|
||
- Update the __init__.py file under the "astronify/" folder to update | ||
the __version__ variable to match the upcoming release version. This | ||
should be specified as a string. | ||
|
||
- Update the version information and release date in the CITATION.cff | ||
file, located in the top-level directory to match the upcoming release version. | ||
|
||
- Update the "CHANGES.rst" file to add the new version, release date, | ||
and summary of what's changing in this version. | ||
|
||
- Make a final commit to the branch, doing things like double checking | ||
Python versions, release dates, spell check documentation files, | ||
etc. Commit the final release with: | ||
|
||
.. code-block:: bash | ||
|
||
$ git commit -m "Preparing release <version>" | ||
|
||
- Tag the commit with the version, using the "v' in front of the tag, | ||
even if the version in the __init__.py file does not. | ||
|
||
.. code-block:: bash | ||
|
||
$ git tag -a v<version> -m "Release version <version>" | ||
|
||
- Make sure the `build` package is up-to-date: | ||
|
||
.. code-block:: bash | ||
|
||
$ python -m build --sdist --outdir dist . | ||
|
||
- Twine upload. | ||
|
||
.. code-block:: bash | ||
|
||
twine upload dist/<my_package*.tar.gz> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll probably want to pull this line out unless you are planning to use this prabg long term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes good call, we should remove, let me try to do so locally and push again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in an all-day class, so I can do at end of day. Or if you have the time and are willing to do so, feel free to kill that line directly? Or we can also take it out as part of the newer PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep things simple, I will remove this as part of that separate PR, along with the other items?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good