Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Update result for test_data_quality_plugin #3390

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jan 15, 2025

Description

The data label has changed from (DQ: 1) to (DQ: 3). Since I don't have an older copy of the MAST image that @bmorris3 used to make that test, I am not sure why. The new label seems in line with existing parser logic in that it uses EXTNUM instead of EXTVER to make the label, so not sure why it was 1 before.

Goal is to fix the test so it does not block unrelated PRs. I am not sure if you want me to refactor the DQ parser.

Filename: jw01895001004_07101_00001_nrca3_cal.fits
No.    Name      Ver    Type      Cards   Dimensions   Format
  0  PRIMARY       1 PrimaryHDU     347   ()
  1  SCI           1 ImageHDU       156   (2048, 2048)   float32
  2  ERR           1 ImageHDU        10   (2048, 2048)   float32
  3  DQ            1 ImageHDU        11   (2048, 2048)   int32 (rescales to uint32)
  4  AREA          1 ImageHDU         9   (2048, 2048)   float32
  5  VAR_POISSON    1 ImageHDU         9   (2048, 2048)   float32
  6  VAR_RNOISE    1 ImageHDU         9   (2048, 2048)   float32
  7  VAR_FLAT      1 ImageHDU         9   (2048, 2048)   float32
  8  ASDF          1 BinTableHDU     11   1R x 1C   [27021B]

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive backport-v4.1.x on-merge: backport to v4.1.x labels Jan 15, 2025
@pllim pllim added this to the 4.1.1 milestone Jan 15, 2025
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (87016c7) to head (2455432).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3390   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files         128      128           
  Lines       19843    19843           
=======================================
+ Hits        17387    17388    +1     
+ Misses       2456     2455    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim marked this pull request as ready for review January 15, 2025 16:57
@pllim
Copy link
Contributor Author

pllim commented Jan 15, 2025

devdeps job failure is unrelated. Note that remote data job now passes with this patch.

@pllim pllim mentioned this pull request Jan 15, 2025
9 tasks
@kecnry
Copy link
Member

kecnry commented Jan 16, 2025

let's merge this for now and follow-up with @bmorris3 if any other changes are needed

@rosteen rosteen merged commit 858f443 into spacetelescope:main Jan 16, 2025
33 of 36 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Jan 16, 2025
@pllim pllim deleted the fix-dq-test branch January 16, 2025 15:54
@pllim
Copy link
Contributor Author

pllim commented Jan 16, 2025

Follow up at 🐱.

pllim added a commit that referenced this pull request Jan 16, 2025
…0-on-v4.1.x

Backport PR #3390 on branch v4.1.x (TST: Update result for test_data_quality_plugin)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.1.x on-merge: backport to v4.1.x no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants