Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptive titles for commonly-accessed pages #35

Closed
wants to merge 17 commits into from

Conversation

benjmor
Copy link

@benjmor benjmor commented Jan 23, 2024

See Issue #34 for design details.

This adds descriptive titles to common pages to support indexing (easy to find a page from your web history) and make it easier to find the tab you're looking for.

Also gosh I hope commits get squashed. Sorry!

@benjmor
Copy link
Author

benjmor commented Jan 23, 2024

All righty @palmertab , the ball is in your court on this one!

@benjmor
Copy link
Author

benjmor commented Jan 29, 2024

Also tagging @ashtarcommunications because why not.

@bmorrissirromb
Copy link

@palmertab - Still no conflicts with these changes! An easy Quality-of-Life win and low-risk since it's summer!

@palmertab
Copy link
Contributor

So this is indeed not a bad idea! However the way you implemented it is actually much harder than it needed to be. You can set it in one place in the autohandler in the top level and it cascades down to all children pages. So I've stolen the idea and implemented it that way.

Given I'm like the last person on earth using Perl/Mason in any meaningful way there's zero shame in not knowing that. And in a month or so (hopefully sooner) I'm intending to feature-freeze the Perl codebase anyway and only permit bug fixes so i can get the JS framework out the door at last.

So I'm technically rejecting this PR but only because I put the idea in myself.

@palmertab palmertab closed this Jul 23, 2024
@bmorrissirromb
Copy link

I thiiiink our implementations are meaningfully different. If I'm reading your commit right, it creates a generic title per tournament, containing the following information:

  • Tournament Webname
  • Tournament Year
  • Tournament Name
  • "Tabroom.com"

So, for every subpage within the Berkeley tournament, you might see: berkeley 2024 Cal Invitational UC Berkeley Tabroom.com as the title (unless I am misunderstanding the Mason code, which as you said, is also likely). Side note: I also currently still see the "Tabroom.com" everywhere, so maybe this change hasn't gone to prod yet.

Anyway, to that design, I say...meh! Most people will have several tabs open for the same tournament, so giving them all the same name won't help people differentiate between them.

The PR I submitted has subtle differences in the Title information for each subpage.

For example, a results subpage will look like:
image

It provides enough identifiers to give you a unique name for the page. That way, if I close the tab, I can type "Round 3" into the Google Chrome Omnibox, find the page, and boom, I'm right back to where I want to be, with no navigation required.

For example, I used this nomenclature for some of the common pages:

  • Tournament splash/"invite" pages: <Name of Tournament>
  • Results pages: Results - <Event Name> - <Round Name> - <Tournament Name>
  • Pairings pages: Pairings - <Event Name> - <Round Name> - <Tournament Name>
  • Entries pages: Entries - <Event Name> - <Tournament Name>
  • Judges pages: Judges - <Tournament Name>

I do like your addition of the tournament year -- that helps disambiguate further. And putting a fallback in the autohandler is still a step in the right direction for uncommonly-accessed pages that don't have special title formats.

Sorry for the novel; hope this clarifies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants