me first a pull request #7

spokik · 2020-09-11T19:07:21Z

No description provided.

В дальнейшем планирую разделить это все на модули. как вариант изучить webpac. Сейчас некоторые браузеры не поддерживают часть функций, (у одной девушки crome v49..._

собираются через функцию

CristinaVolk · 2020-09-26T20:10:49Z

kad.js

@@ -5,9 +5,6 @@ import { windowForUserScript } from './modules/alert.js';
 import { defaultMD } from './modules/autoMD.js';

 if (document.location.href === `https://kad.arbitr.ru/`) { windowForUserScript() }


strings that contain url are better to be stored into const

CristinaVolk · 2020-09-26T20:12:51Z

kad.js

@@ -5,9 +5,6 @@ import { windowForUserScript } from './modules/alert.js';
 import { defaultMD } from './modules/autoMD.js';

 if (document.location.href === `https://kad.arbitr.ru/`) { windowForUserScript() }
-injectFunction();
-
-

 if (document.location.href != `https://kad.arbitr.ru/`) {
  let usersSettings = JSON.parse(localStorage.getItem(`usersSettings`))


try to keep one pattern of quotes, single or double or backward. Usually, if you have just a string use the single quotes ''

CristinaVolk · 2020-09-26T20:14:21Z

modules/addBattons.js

+    footer.innerHTML = `${xc} <div id="activeStat" class="tampleteButton" style="height:23px">Статистика</div>`;
+
+    let classBlok = document.createElement("style")
+    classBlok.innerHTML = "div.tampleteButton{height: 30px;width: 130px;-webkit-appearance: button;-webkit-writing-mode: horizontal-tb !important;color: buttontext;text-shadow: none;display: inline-block;text-align: center;align-items: flex-start;background-color: buttonface;box-sizing: border-box;margin: 0em;font: 400 13.3333px Arial;padding: 1px 6px;border-width: 2px;border-style: outset;border-color: buttonface;border-image: initial;}}";


you can separate html from css. Create a module css and [ut all the styling there ;) when you use everything together it is not possible to change in future when the project grows and it looks dirty, not readable.

CristinaVolk · 2020-09-26T20:16:55Z

modules/addBattons.js

+    for (let index = 0; index < sostavs.length; index++) {
+        let starArray = JSON.parse(localStorage.getItem(`sostav${sostavs[index]}`))
+        for (let key in starArray) {
+            if (starArray[key].month == month) {


try not to compare with ==, use triple one ;)

CristinaVolk · 2020-09-26T20:17:57Z

modules/addBattons.js

+    let today = new Date().getDate()
+    let month = new Date().getMonth() + 1
+    let counter = {}
+    for (let index = 0; index < sostavs.length; index++) {


I believe you can replace this loop with the map method :)

CristinaVolk · 2020-09-26T20:19:11Z

modules/addBattons.js

+        }
+    }
+    //string stringify
+    let stringReturn = ''


try to use more descriptive and meaningful names. It's not clear what you mean by stringReturn, which string? what return? why xd?

CristinaVolk · 2020-09-26T20:27:48Z

modules/addBattons.js

+    let stringReturn = ''
+    for (let key in counter) {
+
+        stringReturn = stringReturn + `${key} состав: ${counter[key]} штук | `


please check if you can replace this loop just by that line:
const stringReturn = counter.map((key, index) => (${index} состав: ${key} штук | ));

Угу, вот только counter = {}

CristinaVolk · 2020-09-27T06:21:40Z

modules/addBattons.js

+    return stringReturn
+}
+
+export { addBattons }


check please the spelling of the filename ;)

CristinaVolk · 2020-09-27T06:22:34Z

modules/addBattons.js

+    let xc = sostavPerDay(usersSettings.usersSS)
+    footer.innerHTML = `${xc} <div id="activeStat" class="tampleteButton" style="height:23px">Статистика</div>`;
+
+    let classBlok = document.createElement("style")


classBlok looks weird tbh , doesn't it?

CristinaVolk · 2020-09-27T06:24:09Z

modules/addStaticOnLocalStorage.js

+    let promise = new Promise((resolve, reject) => {
+        let observer = new MutationObserver((mutationRecords) => {
+            if (mutationRecords.length > 1) {
+                let saveScanStat = document.querySelector("#b-container > div.b-popup-wrapper.js-popup-wrapper.js-popup-wrapper--upload > div.b-popup.b-popup--blue.b-popup--upload.js-popup--upload.b-popup--edit.js-popup--edit > form > div.b-popup-button.js-upload-submit"); // кнопка по которой срабатывает скрипт


please try mot to shorten the names, not to be afraid of using long names. They are descriptive and takes less time to understand what's going on :)

CristinaVolk · 2020-09-27T06:31:54Z

modules/addStaticOnLocalStorage.js

+function addStaticOnLocalStorage() {
+    let elem = document.querySelector("#b-container > div.b-popup-wrapper.js-popup-wrapper.js-popup-wrapper--upload > div.b-popup.b-popup--blue.b-popup--upload.js-popup--upload")
+
+    let promise = new Promise((resolve, reject) => {


if you don't use the parameter reject , then you can add underscore before in order to avoid eslint error/warn .
And if you do not change the variable in code use const instead

CristinaVolk · 2020-09-27T06:34:06Z

README.md

@@ -1,17 +1,17 @@
 # Kad.arbitr
+


Here should be instructions how to run your application in Readme

CristinaVolk · 2020-09-27T06:35:57Z

Scan

-        document.getElementsByClassName(`b-popup-sj-link js-popup-sj-link js-popup-sj-link--upload`)[0].onclick = () =>{document.getElementsByClassName('js-input js-input--combobox js-input--deselect_with_save_val')[1].value = `Материалы по делу`;}
+(function () {
+  "use strict";
+  let usersSettings = JSON.parse(localStorage.getItem(`usersSettings`))


use const if you don't assign a new value ;)

CristinaVolk · 2020-09-27T06:38:42Z

modules/addStaticOnLocalStorage.js

@@ -88,7 +90,7 @@ function addStaticOnLocalStorage() {
  function sostavAtPopup(sostav) {
    const elem = document.createElement("div")
    elem.className = "b-popup-info"
-    elem.innerHTML = `<div class="b-popup-info-title">Состав</div><span class="b-popup-info-text js-popup-info-text" title="${sostav}">${sostav}</span>`
+    elem.innerHTML = `<div class="b-popup-info-title" id="userSS">Состав</div><span class="b-popup-info-text js-popup-info-text" title="${sostav}">${sostav}</span>`
    let isYourSostav = false
    function isCorrectSostav() {
      for (let i = 0; i < usersSettings.usersSS.length; i++) {


the content of this loop can be written just in one line with the help of the ternary operation:
for (let i = 0; i < usersSettings.usersSS.length; i++) { return (isYourSostav = usersSettings.usersSS[i] == sostav ? true : false); }

and also below состав неопределен is it should be necessary the phrase with space before??

CristinaVolk · 2020-09-27T06:54:52Z

modules/addStaticOnLocalStorage.js

+
+            //Срабатывает прии НАЖАТИИ на "Сохранить"
+            params.saveScanStat.onclick = () => {
+                let now = new Date()


please change the name to currentDate for example :)

CristinaVolk · 2020-09-27T06:58:21Z

modules/addStaticOnLocalStorage.js

+                let now = new Date()
+                let dataForLS = {}
+                dataForLS = JSON.parse(localStorage.getItem(`sostav${params.sostav}`))
+                if (dataForLS == null) {


you can reverse this logic of checking :)
check for existence ;)
const dataForLS = JSON.parse(localStorage.getItem(sostav${params.sostav}));
and then if (dataForLS !==null)

CristinaVolk · 2020-09-27T07:01:45Z

modules/addStaticOnLocalStorage.js

+        let observer = new MutationObserver((mutationRecords) => {
+            if (mutationRecords.length > 1) {
+                let saveScanStat = document.querySelector("#b-container > div.b-popup-wrapper.js-popup-wrapper.js-popup-wrapper--upload > div.b-popup.b-popup--blue.b-popup--upload.js-popup--upload.b-popup--edit.js-popup--edit > form > div.b-popup-button.js-upload-submit"); // кнопка по которой срабатывает скрипт
+                let q = document.querySelector("#chrono_list_content > div.b-chrono-items-container.js-chrono-items-container > div").childElementCount  //Кол-во элементов для фикла


you can use such short names for large functions or classes, where another context gives you the entire impression, but here it's tricky to understand

CristinaVolk · 2020-09-27T07:06:35Z

modules/addStaticOnLocalStorage.js

+                let params = {
+                    saveScanStat: saveScanStat,
+                    sostav: sostav,
+                    docId: docId,
+                    a40: a40,


if you use the same names of the props and values , then you don't need to write it twice ;)
let params = { saveScanStat, sostav, docId, a40,

Я собственно так и сделал недавно, правда в другой ветке

CristinaVolk · 2020-09-27T07:15:52Z

modules/addStaticOnLocalStorage.js

+                            .trim() //Удаляет пробелы "с краёв"
+                            .split(` `) //Правращает в масив по разделителю " "
+                        let stringValueCounter = 0
+                        if (stringValueCounter < 2) {


and what if stringValueCounter is equal to 2 ?
I recommend you to change if-else implementation here, it's confusing and long

CristinaVolk · 2020-09-27T07:26:20Z

modules/addTamplaties.js

@@ -1,57 +1,57 @@
 // Добавляет обработчики интерфейса
 function addTamplaties() {


the name :)

CristinaVolk · 2020-09-27T07:29:24Z

modules/addTamplaties.js

@@ -0,0 +1,57 @@
+// Добавляет обработчики интерфейса


you should apply VS formatter here. It's unreadable at all

CristinaVolk · 2020-09-27T07:34:16Z

modules/checkReload.js

+        if (lastFilles === undefined) {
+            lastFilles = {}
+            return lastFilles
+        }


why do you assign an empty object?
you can check the value to exist and proceed

Я уже не помню, оно без этого не работало XD

CristinaVolk · 2020-09-27T07:37:46Z

modules/statisticsInterface.js

+        let classBlok = document.createElement("style")
+        classBlok.innerHTML = `
+    body {
+      margin: 0;
+      padding: 0;
+      background: #f3f3f3;
+    }
+    .settings {
+      position: absolute;
+      left: 82%;
+      top: 40px;
+      width: 250px;
+      border: 1px solid rgb(205 205 224);
+      padding: 5px;
+      color: rgb(255 255 255);
+      background: rgb(50 50 51);
+      display: block;
+    }
+    #word_opts {
+      position: relative;
+      padding: 4px;
+      width: 60px;
+      height: 60px;
+      background: #c6c6c6;
+      outline: none;
+      border-radius: 7px;
+      box-shadow: inset 0 0 5px rgba(0,0,0, .2);
+      transition: 0.5s;
+    }
+
+    label input[type="checkbox"]:checked + #word_opts {
+      background: #02a9f4;
+    }
+
+    input[type="checkbox"] {
+      width: 40px;
+      height: 20px;
+      -webkit-appearance: none;
+      -moz-appearance: none;
+      background: #c6c6c6;
+      outline: none;
+      border-radius: 50px;
+      box-shadow: inset 0 0 5px rgba(0,0,0, .2);
+      transition: 0.5s;
+      position: absolute;
+      right: 40px;
+    }
+    input:checked[type="checkbox"] {
+      background: #02a9f4;
+    }
+    input[type="checkbox"]::before {
+      content: '';
+      position: absolute;
+      width: 20px;
+      height: 20px;
+      border-radius: 50%;
+      top: 0;
+      left: 0;
+      background: #fff;
+      transform: scale(1.1);
+      box-shadow: 0 2px 5px rgba(0,0,0, .2);
+      transition: 0.5s;
+    }
+    input:checked[type="checkbox"]::before {
+      left: 20px;
+    }
+    `


you need to extract all the css to the css module :)

ok. I will be try

CristinaVolk · 2020-09-27T07:42:47Z

modules/alert.js

+        if (year20 == true) { year = 20; }
+        else if (year19 == true) { year = 19; }
+        else if (year18 == true) { year = 18; }
+        else { alert(`ЕРОР! Чет какая - то шляпа введина в место года`) }


you can use ternary operators here

CristinaVolk · 2020-09-27T07:43:33Z

modules/alert.js

+    //пересобирает строку, заменя 2 последний цифры
+    function setYear(year) {
+        let newNumber = document.querySelector(`#sug - cases.tag input[type = "text"]: valid`).value
+        let inString = document.querySelector(`#sug - cases.tag input[type = "text"]: valid`).value["length"]


i don't like the name XD

CristinaVolk · 2020-09-27T07:44:14Z

modules/alert.js

+    }
+
+
+    //Красим фон и меняем год


if you use comments, it means you use bad names ;)

CristinaVolk · 2020-09-27T07:47:24Z

modules/statisticsInterface.js

+      for (let i = 0; i < document.querySelectorAll("#settings > input[type=checkbox]").length; i++) {
+        let x = document.querySelectorAll("#settings > input[type=checkbox]")[i]
+        if (x.checked) {
+          preSet[x.name] = "checked"
+        } else {
+          preSet[x.name] = ""
+        }

-            localStorage.setItem(`usersSettings`, JSON.stringify(preSet))
-        })
+      }
+      preSet.usersSS = []


too long, i believe you can reduce it with the help of methods of js and ternary operators ;)

CristinaVolk · 2020-09-27T07:48:14Z

modules/usersSettings.js

@@ -1,13 +1,13 @@
 const usersSettings = JSON.parse(localStorage.getItem(`usersSettings`))
 if (usersSettings == undefined) {


if (!usersSettings)

…пределен. не тестилось

Давно не занимался проектом, не помню где ошибки. Не хочу разбираться. Кажется более простым вариантом вернуться к рабочей версии и плясать от нее

spokik and others added 11 commits September 8, 2020 17:02

last work version from my job

b0b8462

Частично реализованны модули

f20eb6c

Перенес авто Мд в модуль

8eed0a5

modules.js модули

56fa94a

собираются через функцию

Все разнесено по модулям

943851b

rename and correct mistakes in selectYear

d9b9d26

Исправлена табуляция на единую в 2 пробела

ac973a2

Не добавляет кучу составов при мутации элемента

b9c8756

Merge branch 'spokik-dev-events' into spokik-as-extension

396c8c2

asd

d6be03a

CristinaVolk reviewed Sep 26, 2020

View reviewed changes

CristinaVolk reviewed Sep 27, 2020

View reviewed changes

modules/addBattons.js

return stringReturn

}

export { addBattons }

Copy link

CristinaVolk Sep 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check please the spelling of the filename ;)

CristinaVolk reviewed Sep 27, 2020

View reviewed changes

README.md

@@ -1,17 +1,17 @@

# Kad.arbitr

Copy link

CristinaVolk Sep 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here should be instructions how to run your application in Readme

CristinaVolk reviewed Sep 27, 2020

View reviewed changes

оп, Хлоп

8af5fef

CristinaVolk reviewed Sep 27, 2020

View reviewed changes

modules/alert.js Outdated

}

//Красим фон и меняем год

Copy link

CristinaVolk Sep 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you use comments, it means you use bad names ;)

CristinaVolk reviewed Sep 27, 2020

View reviewed changes

spokik and others added 6 commits September 27, 2020 12:01

тык

fc222e0

Добавилась генирация конок выбора состава, в случае, если состав не о…

41f14aa

…пределен. не тестилось

readme по бырому

10dbe84

йцу

ee18327

Восстанавливаю из рабочей версии

cb6f254

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

me first a pull request #7

me first a pull request #7

spokik commented Sep 11, 2020

CristinaVolk Sep 26, 2020

CristinaVolk Sep 26, 2020 •

edited

Loading

CristinaVolk Sep 26, 2020 •

edited

Loading

CristinaVolk Sep 26, 2020

CristinaVolk Sep 26, 2020

CristinaVolk Sep 26, 2020

CristinaVolk Sep 26, 2020 •

edited

Loading

spokik Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

spokik Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

spokik Sep 27, 2020

CristinaVolk Sep 27, 2020

spokik Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

CristinaVolk Sep 27, 2020

		@@ -5,9 +5,6 @@ import { windowForUserScript } from './modules/alert.js';
		import { defaultMD } from './modules/autoMD.js';

		if (document.location.href === `https://kad.arbitr.ru/`) { windowForUserScript() }

		@@ -1,57 +1,57 @@
		// Добавляет обработчики интерфейса
		function addTamplaties() {

		@@ -0,0 +1,57 @@
		// Добавляет обработчики интерфейса

		@@ -1,13 +1,13 @@
		const usersSettings = JSON.parse(localStorage.getItem(`usersSettings`))
		if (usersSettings == undefined) {

me first a pull request #7

Are you sure you want to change the base?

me first a pull request #7

Conversation

spokik commented Sep 11, 2020

Choose a reason for hiding this comment

CristinaVolk Sep 26, 2020 • edited Loading

Choose a reason for hiding this comment

CristinaVolk Sep 26, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CristinaVolk Sep 26, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CristinaVolk Sep 26, 2020 •

edited

Loading

CristinaVolk Sep 26, 2020 •

edited

Loading

CristinaVolk Sep 26, 2020 •

edited

Loading