Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

me first a pull request #7

Open
wants to merge 18 commits into
base: spokik-dev-events
Choose a base branch
from
Open

me first a pull request #7

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b0b8462
last work version from my job
spokik Sep 8, 2020
1bd5e02
Пересобрал в виде расширения
spokik Sep 18, 2020
f20eb6c
Частично реализованны модули
spokik Sep 19, 2020
8eed0a5
Перенес авто Мд в модуль
spokik Sep 20, 2020
56fa94a
modules.js модули
spokik Sep 20, 2020
943851b
Все разнесено по модулям
spokik Sep 20, 2020
d9b9d26
rename and correct mistakes in selectYear
spokik Sep 20, 2020
ac973a2
Исправлена табуляция на единую в 2 пробела
spokik Sep 20, 2020
b9c8756
Не добавляет кучу составов при мутации элемента
spokik Sep 22, 2020
396c8c2
Merge branch 'spokik-dev-events' into spokik-as-extension
spokik Sep 26, 2020
d6be03a
asd
spokik Sep 26, 2020
8af5fef
оп, Хлоп
spokik Sep 27, 2020
fc222e0
тык
spokik Sep 27, 2020
41f14aa
Добавилась генирация конок выбора состава, в случае, если состав не о…
spokik Sep 28, 2020
10dbe84
readme по бырому
spokik Sep 28, 2020
ee18327
йцу
spokik Sep 29, 2020
27e0310
Восстанавливаю из рабочей версии
spokik Nov 9, 2020
cb6f254
Восстанавливаю из рабочей версии
spokik Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions modules/addStaticOnLocalStorage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,10 @@ function addStaticOnLocalStorage() {
else { sostav = ' состав неопределен' }
}
}

sostavAtPopup(sostav)
if(document.querySelector(`#userSS`) === null){
sostavAtPopup(sostav)
}


let params = {
saveScanStat: saveScanStat,
Expand Down Expand Up @@ -88,7 +90,7 @@ function addStaticOnLocalStorage() {
function sostavAtPopup(sostav) {
const elem = document.createElement("div")
elem.className = "b-popup-info"
elem.innerHTML = `<div class="b-popup-info-title">Состав</div><span class="b-popup-info-text js-popup-info-text" title="${sostav}">${sostav}</span>`
elem.innerHTML = `<div class="b-popup-info-title" id="userSS">Состав</div><span class="b-popup-info-text js-popup-info-text" title="${sostav}">${sostav}</span>`
let isYourSostav = false
function isCorrectSostav() {
for (let i = 0; i < usersSettings.usersSS.length; i++) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the content of this loop can be written just in one line with the help of the ternary operation:
for (let i = 0; i < usersSettings.usersSS.length; i++) { return (isYourSostav = usersSettings.usersSS[i] == sostav ? true : false); }

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also below состав неопределен is it should be necessary the phrase with space before??

Expand Down