Feat/support unencoded jwt authorization requests #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
Signed-off-by: Ryan Tate <[email protected]>
…r values Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate
changed the base branch from
main
to
feat/add-req-obj-signing-alg-setter-wallet-metadata
Ryanmtate
force-pushed
the
feat/support-unencoded-jwt-authorization-requests
branch
from
c589019 to
24607cc
Compare
|
Changes in SSI have resolved this. |
|
This short circuit for avoiding the check whether the client id of the verifier (DID) in relation to the key ID in the header may still be helpful. However, this may not be the correct way to handle whether or not a |
Ryanmtate
force-pushed
the
feat/support-unencoded-jwt-authorization-requests
branch
2 times, most recently
from
12ba6e9 to
349cb7d
Compare
Ryanmtate
changed the base branch from
feat/add-req-obj-signing-alg-setter-wallet-metadata
to
feat/vp-data-integrity-cryptosuite
Ryanmtate
approved these changes
Nov 18, 2024
Signed-off-by: Ryan Tate <[email protected]>
Ryanmtate
force-pushed
the
feat/support-unencoded-jwt-authorization-requests
branch
from
349cb7d to
f1ecd8b
Compare
Joey-Silberman
merged commit 55b36f9
into
feat/vp-data-integrity-cryptosuite
2 checks passed
Joey-Silberman
deleted the
feat/support-unencoded-jwt-authorization-requests
branch
Ryanmtate
added a commit
that referenced
this pull request
Nov 21, 2024
* Add temporary support for unencoded JWT authorization requests * Remove unnecessary comment * use serde deserialize serialize derive for authorization response Signed-off-by: Ryan Tate <[email protected]> * update url encoding for auth response Signed-off-by: Ryan Tate <[email protected]> * fix unit tests Signed-off-by: Ryan Tate <[email protected]> * use custom struct for json string encoded authorization response inner values Signed-off-by: Ryan Tate <[email protected]> * allow unencoded authorization request Signed-off-by: Ryan Tate <[email protected]> --------- Signed-off-by: Ryan Tate <[email protected]> Co-authored-by: Joey Silberman <[email protected]> Co-authored-by: Ryan Tate <[email protected]>
Ryanmtate
added a commit
that referenced
this pull request
Dec 1, 2024
* add request object signing algorithm setter method Signed-off-by: Ryan Tate <[email protected]> * return application json encoded authorization response (#39) * use serde deserialize serialize derive for authorization response Signed-off-by: Ryan Tate <[email protected]> * update url encoding for auth response Signed-off-by: Ryan Tate <[email protected]> * fix unit tests Signed-off-by: Ryan Tate <[email protected]> * use custom struct for json string encoded authorization response inner values Signed-off-by: Ryan Tate <[email protected]> --------- Signed-off-by: Ryan Tate <[email protected]> * bump serde_json_path version Signed-off-by: Ryan Tate <[email protected]> * Add temporary support for unencoded JWT authorization requests * Remove unnecessary comment * Start implementation for VpTokenItem From method for specific JsonPresentation Signed-off-by: Ryan Tate <[email protected]> Co-Authored-By: Joey Silberman <[email protected]> * use ssi 0.10.1 release Signed-off-by: Ryan Tate <[email protected]> * add data integrity conversion for vp token Additionally adds a check for authorization request vp formats supported to check cryptosuite against expected response formats. Signed-off-by: Ryan Tate <[email protected]> * update data integrity vp token from conversion Signed-off-by: Ryan Tate <[email protected]> * Feat/support unencoded jwt authorization requests (#40) * Add temporary support for unencoded JWT authorization requests * Remove unnecessary comment * use serde deserialize serialize derive for authorization response Signed-off-by: Ryan Tate <[email protected]> * update url encoding for auth response Signed-off-by: Ryan Tate <[email protected]> * fix unit tests Signed-off-by: Ryan Tate <[email protected]> * use custom struct for json string encoded authorization response inner values Signed-off-by: Ryan Tate <[email protected]> * allow unencoded authorization request Signed-off-by: Ryan Tate <[email protected]> --------- Signed-off-by: Ryan Tate <[email protected]> Co-authored-by: Joey Silberman <[email protected]> Co-authored-by: Ryan Tate <[email protected]> * Update src/core/metadata/parameters/verifier.rs Co-authored-by: Jacob <[email protected]> Signed-off-by: Ryan Tate <[email protected]> --------- Signed-off-by: Ryan Tate <[email protected]> Co-authored-by: Joey Silberman <[email protected]> Co-authored-by: Joey Silberman <[email protected]> Co-authored-by: Jacob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for unencoded/unsigned jwt authorization requests to bypass KID and signature checks in request validation for when
client_id_schemeisdid. This is necessary for using VC playground verifier QRs because theirrequest_jwtis unsigned and thus doesn't have a KID.