Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/support unencoded jwt authorization requests #40

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Feat/support unencoded jwt authorization requests #40

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d01c6e4
Add temporary support for unencoded JWT authorization requests
Oct 31, 2024
c589019
Remove unnecessary comment
Oct 31, 2024
73e3a13
use serde deserialize serialize derive for authorization response
Ryanmtate Oct 31, 2024
4f9c3fc
update url encoding for auth response
Ryanmtate Oct 31, 2024
7641fb9
fix unit tests
Ryanmtate Oct 31, 2024
eef7f70
use custom struct for json string encoded authorization response inne…
Ryanmtate Oct 31, 2024
f1ecd8b
allow unencoded authorization request
Ryanmtate Nov 18, 2024
e5367e2
rebasing off origin branch
Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/core/authorization_request/verification/did.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@ pub async fn verify_with_resolver(
bail!("request was signed with unsupported algorithm: {alg}")
}

// This bypass is for unencoded JWT requests, but we will need to change this later
// so that trust is preserved when receiving unencoded requests
// NOTE: This requires that `Algorithm::None` is permitted in the wallet metadata
// Otherwise, this function will error in the previous assertion.
if alg.contains("none") {
return Ok(());
}

let Json::String(kid) = headers
.remove("kid")
.context("'kid' was missing from jwt headers")?
Expand Down
Loading