chore(starknet_committer_and_os_cli): moved block-hash logic into separate folder #3842
+70
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
amosStarkware
force-pushed
the
01-30-chore_starknet_committer_and_os_cli_moved_block-hash_logic_into_separate_folder
branch
from
d198e43 to
083eb6b
Compare
dorimedini-starkware
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)
dorimedini-starkware
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)
a discussion (no related file):
need py side pr
This was referenced Feb 2, 2025
amosStarkware
force-pushed
the
01-29-chore_starknet_committer_and_os_cli_moved_committer_logic_into_separate_folder
branch
from
af0c1bd to
9a83178
Compare
amosStarkware
force-pushed
the
01-30-chore_starknet_committer_and_os_cli_moved_block-hash_logic_into_separate_folder
branch
from
083eb6b to
e1b860f
Compare
amosStarkware
force-pushed
the
01-29-chore_starknet_committer_and_os_cli_moved_committer_logic_into_separate_folder
branch
from
9a83178 to
da0e82a
Compare
amosStarkware
force-pushed
the
01-30-chore_starknet_committer_and_os_cli_moved_block-hash_logic_into_separate_folder
branch
from
e1b860f to
4b7e7b2
Compare
amosStarkware
force-pushed
the
01-29-chore_starknet_committer_and_os_cli_moved_committer_logic_into_separate_folder
branch
from
da0e82a to
c332cc6
Compare
amosStarkware
force-pushed
the
01-30-chore_starknet_committer_and_os_cli_moved_block-hash_logic_into_separate_folder
branch
from
4b7e7b2 to
c7cf596
Compare
dorimedini-starkware
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Reviewable status:
amosStarkware
force-pushed
the
01-29-chore_starknet_committer_and_os_cli_moved_committer_logic_into_separate_folder
branch
from
c332cc6 to
34298e6
Compare
amosStarkware
force-pushed
the
01-30-chore_starknet_committer_and_os_cli_moved_block-hash_logic_into_separate_folder
branch
from
c7cf596 to
113d8cb
Compare
ArniStarkware
changed the base branch from
01-29-chore_starknet_committer_and_os_cli_moved_committer_logic_into_separate_folder
to
main
Merge activity
|
amosStarkware
force-pushed
the
01-30-chore_starknet_committer_and_os_cli_moved_block-hash_logic_into_separate_folder
branch
from
113d8cb to
e305e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.