Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_committer_and_os_cli): renamed committer_cli_push to committer_and_os_cli_push #3874

Open
wants to merge 1 commit into
base: 02-02-chore_starknet_committer_and_os_cli_separate_block-hash_tests
Choose a base branch
from

Conversation

amosStarkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@amosStarkware amosStarkware force-pushed the 02-02-chore_starknet_committer_and_os_cli_separate_block-hash_tests branch from 56ed406 to 69cf0ae Compare February 2, 2025 12:52
@amosStarkware amosStarkware force-pushed the 02-02-chore_starknet_committer_and_os_cli_renamed_committer_cli_push.yml_to_committer_and_os_cli_push.yml branch from 6b4efe2 to 2b8a75c Compare February 2, 2025 12:53
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)


.github/workflows/committer_and_os_cli_push.yml line 1 at r1 (raw file):

name: Committer-CLI-push

Suggestion:

Committer-And-OS-CLI-push

@amosStarkware amosStarkware force-pushed the 02-02-chore_starknet_committer_and_os_cli_renamed_committer_cli_push.yml_to_committer_and_os_cli_push.yml branch from 2b8a75c to 4ef048e Compare February 2, 2025 14:50
Copy link
Collaborator Author

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


.github/workflows/committer_and_os_cli_push.yml line 1 at r1 (raw file):

name: Committer-CLI-push

Done.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

@amosStarkware amosStarkware force-pushed the 02-02-chore_starknet_committer_and_os_cli_renamed_committer_cli_push.yml_to_committer_and_os_cli_push.yml branch from 4ef048e to fab88ac Compare February 3, 2025 08:51
@amosStarkware amosStarkware changed the title chore(starknet_committer_and_os_cli): renamed committer_cli_push.yml to committer_and_os_cli_push.yml chore(starknet_committer_and_os_cli): renamed committer_cli_push to committer_and_os_cli_push Feb 3, 2025
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants