-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(starknet_integration_tests): extract test contracts #4009
Conversation
Graphite Automations"Yair - Auto-assign" took an action on this PR • (02/06/25)1 assignee was added to this PR based on Yair's automation. |
9533d64
to
5164302
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
crates/starknet_integration_tests/src/state_reader.rs
line 167 at r1 (raw file):
chain_info: &ChainInfo, test_defined_accounts: Vec<AccountTransactionGenerator>, preset_test_contracts: PresetTestContracts,
Unpack in the beginning, so that accessing its fields isn't a long line. Throughout the PR.
Code quote:
PresetTestContracts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yair-starkware)
5164302
to
b1c7c76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
crates/starknet_integration_tests/src/state_reader.rs
line 167 at r1 (raw file):
Previously, elintul (Elin) wrote…
Unpack in the beginning, so that accessing its fields isn't a long line. Throughout the PR.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
First step towards extracting all the classes outside `initialize_papyrus_test_state` so we can write them to the class manager storage.
b1c7c76
to
69504b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
First steo towards extracting all the classes outside
initialize_papyrus_test_state
so we can write them to the class manager storage.