Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_integration_tests): extract test contracts #4009

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

yair-starkware
Copy link
Contributor

First steo towards extracting all the classes outside initialize_papyrus_test_state so we can write them to the class manager storage.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

graphite-app bot commented Feb 6, 2025

Graphite Automations

"Yair - Auto-assign" took an action on this PR • (02/06/25)

1 assignee was added to this PR based on Yair's automation.

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)


crates/starknet_integration_tests/src/state_reader.rs line 167 at r1 (raw file):

    chain_info: &ChainInfo,
    test_defined_accounts: Vec<AccountTransactionGenerator>,
    preset_test_contracts: PresetTestContracts,

Unpack in the beginning, so that accessing its fields isn't a long line. Throughout the PR.

Code quote:

PresetTestContracts

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yair-starkware)

@yair-starkware yair-starkware force-pushed the yair/extract_preset_contracts branch from 5164302 to b1c7c76 Compare February 9, 2025 09:35
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

Copy link
Contributor Author

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)


crates/starknet_integration_tests/src/state_reader.rs line 167 at r1 (raw file):

Previously, elintul (Elin) wrote…

Unpack in the beginning, so that accessing its fields isn't a long line. Throughout the PR.

Done

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

First step towards extracting all the classes outside
`initialize_papyrus_test_state` so we can write them to the class manager storage.
@yair-starkware yair-starkware force-pushed the yair/extract_preset_contracts branch from b1c7c76 to 69504b4 Compare February 9, 2025 09:59
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

@yair-starkware yair-starkware added this pull request to the merge queue Feb 9, 2025
Merged via the queue into main with commit fdf4886 Feb 9, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants