refactor(starknet_class_manager): builder for test storage

[yair-starkware]

No description provided.

[yair-starkware]

• fix(starknet_sequencer_node): use the real class manager client #4040
• feat(starknet_integration_tests): init the class manage storage with classes #4015
• refactor(starknet_integration_tests): use test storage builder #4012
• refactor(starknet_class_manager): builder for test storage #4011 👈 (View in Graphite)
• refactor(starknet_integration_tests): move classes outside #4010
• refactor(starknet_integration_tests): extract test contracts #4009
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[graphite-app]

Graphite Automations

"Yair - Auto-assign" took an action on this PR • (02/06/25)

1 assignee was added to this PR based on Yair's automation.

[elintul]

Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @yair-starkware)

---

crates/starknet_class_manager/src/test_utils.rs line 21 at r2 (raw file):

        let persistent_root = persistent_root_handle.path().to_path_buf();
        let config = FsClassStorageConfig {
            persistent_root,

For consistency with path_prefix.

Suggestion:

        let config = FsClassStorageConfig {
            persistent_root: persistent_root_handle.path().to_path_buf(),

---

crates/starknet_class_manager/src/test_utils.rs line 44 at r2 (raw file):

    }

    pub fn build(self) -> (FsClassStorage, FsClassStorageConfig, Option<FileHandles>) {

Shouldn't build method of builder return the object it builds (here, FsClassStorage)?

Code quote:

build

---

crates/starknet_class_manager/src/test_utils.rs line 47 at r2 (raw file):

        let Self { config, handles } = self;
        let class_hash_storage =
            ClassHashStorage::new(config.class_hash_storage_config.clone()).unwrap();

Unwrap config insead?

Code quote:

config.class_hash_storage_config.clone()

[yair-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @elintul)

---

crates/starknet_class_manager/src/test_utils.rs line 21 at r2 (raw file):

Previously, elintul (Elin) wrote…

For consistency with path_prefix.

Done

---

crates/starknet_class_manager/src/test_utils.rs line 44 at r2 (raw file):

Previously, elintul (Elin) wrote…

Shouldn't build method of builder return the object it builds (here, FsClassStorage)?

It returns it, along with the final config and the file handles

---

crates/starknet_class_manager/src/test_utils.rs line 47 at r2 (raw file):

Previously, elintul (Elin) wrote…

Unwrap config insead?

The config is not an option.
I need to clone it because the constructor moves it, and I need to return it to the user.

[yair-starkware]

Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @elintul)