Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_integration_tests): add support for specifying a costum config dir path #4062

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Feb 10, 2025

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware changed the base branch from spr/main/daf3715e to main February 13, 2025 17:52
@nadin-Starkware nadin-Starkware changed the title chore(starknet_integration_tests): add support for specifying a costum config dir path chore(starknet_integration_tests): add support for specifying a costu… Feb 13, 2025
@nadin-Starkware nadin-Starkware added this pull request to the merge queue Feb 13, 2025
@nadin-Starkware nadin-Starkware changed the title chore(starknet_integration_tests): add support for specifying a costu… chore(starknet_integration_tests): add support for specifying a costum config dir path Feb 13, 2025
Merged via the queue into main with commit 7319f20 Feb 13, 2025
17 of 30 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants