-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starknet_integration_tests): add generate test presets bin #4064
base: spr/main/f520149e
Are you sure you want to change the base?
Conversation
1da6247
to
0f0ec7a
Compare
b348182
to
29e0b85
Compare
0f0ec7a
to
bc9fc17
Compare
29e0b85
to
5693919
Compare
bc9fc17
to
60e1d02
Compare
60e1d02
to
97bcf17
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion
crates/starknet_integration_tests/src/bin/test_presets_generator.rs
line 23 at r1 (raw file):
.await; info!("Finished generating config files.");
Is this about just the config files, or the storage setup as well?
Assuming the latter, please rename this binary and info messages to better reflect this.
Code quote:
generating config files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)
crates/starknet_integration_tests/src/bin/test_presets_generator.rs
line 14 at r1 (raw file):
info!("Generate config files under {:?}", args.preset_dir); let (_sequencers_setup, _node_indices) = get_sequencer_setup_configs(
Needed?
Code quote:
let (_sequencers_setup, _node_indices) =
97bcf17
to
fd7a76a
Compare
95db2a3
to
dfc3669
Compare
dfc3669
to
480aac6
Compare
fd7a76a
to
be12482
Compare
Benchmark movements: |
commit-id:c7a6707e
480aac6
to
e593340
Compare
be12482
to
230dec5
Compare
Stack: