Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_integration_tests): add generate test presets bin #4064

Open
wants to merge 1 commit into
base: spr/main/f520149e
Choose a base branch
from

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Feb 10, 2025

@reviewable-StarkWare
Copy link

This change is Reviewable

@nadin-Starkware nadin-Starkware force-pushed the spr/main/c7a6707e branch 3 times, most recently from 1da6247 to 0f0ec7a Compare February 10, 2025 16:47
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.948 ms 35.071 ms 35.244 ms]
change: [-4.2729% -2.6611% -1.2349%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion


crates/starknet_integration_tests/src/bin/test_presets_generator.rs line 23 at r1 (raw file):

    .await;

    info!("Finished generating config files.");

Is this about just the config files, or the storage setup as well?
Assuming the latter, please rename this binary and info messages to better reflect this.

Code quote:

generating config files

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)


crates/starknet_integration_tests/src/bin/test_presets_generator.rs line 14 at r1 (raw file):

    info!("Generate config files under {:?}", args.preset_dir);
    let (_sequencers_setup, _node_indices) = get_sequencer_setup_configs(

Needed?

Code quote:

let (_sequencers_setup, _node_indices) =

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.688 ms 34.712 ms 34.740 ms]
change: [-2.4302% -2.2918% -2.1534%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants