Enable samplebot sample on melodic

[Naoki-Hiraoka]

This PR includes #246, #249.
Samplerobot walked in melodic

The video is 10x fast because my PC (ThinkPad T440s) is not so fast and simulation is slow.

[Naoki-Hiraoka]

TRAVIS PASSED!!!

[pazeshun]

What is this .rosinstall for?
Could you write usage of this on README?

[Naoki-Hiraoka]

This file is same as .travis.rosinstall of master.
I think we don't need this file, and I don't know the usage of some packages like https://svn.code.sf.net/p/jsk-ros-pkg/code/trunk/openrave_planning/collada_robots.
But I could not erase this file because these URL may be needed in the future.

[pazeshun]

I see. How about just commenting out unnecessary lines of .travis.rosinstall and adding comments like (@Naoki-Hiraoka) I don't know what is for
I think jsk_model_tools, jsk_roseus, and collada_robots are added at #36 .
And nowadays, we can use jsk_model_tools and jsk_roseus from apt, so they are no more required and can be removed even from comments.
@k-okada Do you remember why you added collada_robots?
I searched source code at c5ea4a4, but I couldn't find about collada_robots.

[Naoki-Hiraoka]

Thank you. I fixed it.

[pazeshun]

@k-okada

@k-okada Do you remember why you added collada_robots?
I searched source code at c5ea4a4, but I couldn't find about collada_robots.

Sorry, but do you have any comment about this?

[pazeshun]

Could you also test this on kinetic?

[Naoki-Hiraoka]

Could you also test this on kinetic?

I have tested this PR on my kinetic PC now. SampleRobot sample successfully worked.

[Naoki-Hiraoka]

@pazeshun @k-okada
It was reported that this PR worked without problems in a b4 environment.
I would like to merge this PR and #251.
Is there something I need to fix?

(After this PR is merged, we will be able to test start-jsk/rtmros_tutorials and then test start-jsk/rtmros_hrp2 start-jsk/rtmros_choreonoid for melodic)

[pazeshun]

@Naoki-Hiraoka @k-okada
We stopped at #250 (comment)

[knorth55]

I checked with my melodic robot, and it successfully walked!

[Naoki-Hiraoka]

On melodic, /opt/ros/melodic/share/hrpsys/srcis not installed with ros-melodic-hrpsys, so hrpsys_gazebo_general/iob needs to be built with hrpsys source.

[k-okada]

On melodic, /opt/ros/melodic/share/hrpsys/srcis not installed with ros-melodic-hrpsys, so hrpsys_gazebo_general/iob needs to be built with hrpsys source.

if we release hrpsys on meloidc, can we remove them from .rosinstall? if so we can remove

rtmros_gazebo/.travis.rosinstall.kinetic

Lines 12 to 14 in c8421d8

	- git:
	uri: https://github.com/fkanehiro/hrpsys-base
	local-name: hrpsys

Or, do we need latest version of hrpsys to let SampleRobot walk?

[Naoki-Hiraoka]

On melodic, /opt/ros/melodic/share/hrpsys/srcis not installed with ros-melodic-hrpsys, so hrpsys_gazebo_general/iob needs to be built with hrpsys source.

if we release hrpsys on meloidc, can we remove them from .rosinstall? if so we can remove

rtmros_gazebo/.travis.rosinstall.kinetic

Lines 12 to 14 in c8421d8

	- git:
	uri: https://github.com/fkanehiro/hrpsys-base
	local-name: hrpsys

Or, do we need latest version of hrpsys to let SampleRobot walk?

We do not need latest version of hrpsys to let SampleRobot walk.

I'm wondering what .rosinstall should be.
As you said, we can remove .rosinstall and small .rosinstall is better.
On the other hand, it is better to test both with and without latest version of hrpsys because many researchers use latest version of hrpsys. We can test both situation by setting USE_DEB=true(without latest version of hrpsys) or USE_DEB=false(with latest version of hrpsys) respectively.

Could you tell me what kind of policy we should take?
This decision will affect .rosinstall of rtmros_gazebo, rtmros_tutorials, rtmros_hrp2, rtmros_choreonoid, ....

[pazeshun]

@k-okada @Naoki-Hiraoka

We can test both situation by setting USE_DEB=true(without latest version of hrpsys) or USE_DEB=false(with latest version of hrpsys) respectively.

I think we sometimes have three situations about travis testing of a package as follows:

• Test the package on travis with released deb of the other packages (USE_DEB=true)
• Test the package on travis with source of some other packages because they are not released
• Test the package on travis with source of some other packages in order to check if the target package works with the latest version of other packages

Can we separate the second and the third situations?
I know USE_DEB=false and USE_DEB=source exist, but I don't know which to use for each situation.

In @Naoki-Hiraoka 's case, hrpsys exists for the third situation.

[Naoki-Hiraoka]

I opened new PR #255 .