Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for assets that require cloud formation #5522

Merged
merged 1 commit into from
Feb 20, 2025
Merged

feat: support for assets that require cloud formation #5522

merged 1 commit into from
Feb 20, 2025

Conversation

sprutton1
Copy link
Contributor

This adds support for creating assets that do not have cloud control support via cloud formation. For these assets, we:

  • remove all output sockets
  • remove all mgmt functions
  • remove all codegen funcs except the linter
  • add an output socket for the cloud formation bits
  • add an attribute function that populates that output socket

Other cleanup included:

  • remove some unused funcs
  • remove Clover signature from assets
  • remove AWS::IAM:: assets

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@vbustamante
Copy link
Contributor

closes ENG-2945

vbustamante
vbustamante previously approved these changes Feb 20, 2025
View reviewed changes
@sprutton1 sprutton1 added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@sprutton1 sprutton1 added this pull request to the merge queue Feb 20, 2025
@sprutton1 sprutton1 removed this pull request from the merge queue due to a manual request Feb 20, 2025
@sprutton1 sprutton1 enabled auto-merge February 20, 2025 21:51
@sprutton1 sprutton1 added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 4184ba7 Feb 20, 2025
9 checks passed
@sprutton1 sprutton1 deleted the clover/cf-assets branch February 20, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbustamante vbustamante vbustamante approved these changes

@jkeiser jkeiser Awaiting requested review from jkeiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sprutton1 @vbustamante