Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for assets that require cloud formation #5522

Merged
merged 1 commit into from
Feb 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
async function main(input: Input): Promise<Output> {
const properties = _.cloneDeep(input.cfnProperties);
delete properties["extra"];
const result = {
"LogicalResourceName": input.cfnLogicalResourceName,
"Type": input.cfnType,
"Properties": properties,
};
return JSON.stringify(result);
}

This file was deleted.

This file was deleted.

13 changes: 9 additions & 4 deletions bin/clover/src/commands/generateSiSpecs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { getExistingSpecs } from "../specUpdates.ts";

import _logger from "../logger.ts";
import { assetSpecificOverrides } from "../pipeline-steps/assetSpecificOverrides.ts";
import { addSignatureToCategoryName } from "../pipeline-steps/addSignatureToCategoryName.ts";
import { generateOutputSocketsFromProps } from "../pipeline-steps/generateOutputSocketsFromProps.ts";
import {
ExpandedPkgSpec,
Expand All @@ -27,11 +26,12 @@ import { prettifySocketNames } from "../pipeline-steps/prettifySocketNames.ts";
import { loadInferred } from "../spec/inferred.ts";
import { addInferredEnums } from "../pipeline-steps/addInferredEnums.ts";
import { PkgSpec } from "../bindings/PkgSpec.ts";
import { ignoreSpecsWithoutHandlers } from "../pipeline-steps/ignoreSpecsWithoutHandlers.ts";
import { SchemaVariantSpec } from "../bindings/SchemaVariantSpec.ts";
import { SchemaSpec } from "../bindings/SchemaSpec.ts";
import { bfsPropTree, ExpandedPropSpec } from "../spec/props.ts";
import { PropSpec } from "../bindings/PropSpec.ts";
import { pruneCfAssets } from "../pipeline-steps/pruneCfAssets.ts";
import { removeUnneededAssets } from "../pipeline-steps/removeUnneededAssets.ts";

const logger = _logger.ns("siSpecs").seal();
const SI_SPEC_DIR = "si-specs";
Expand Down Expand Up @@ -70,7 +70,6 @@ export async function generateSiSpecs(
}

// EXECUTE PIPELINE STEPS
specs = ignoreSpecsWithoutHandlers(specs);
specs = addInferredEnums(specs, inferred);
specs = generateOutputSocketsFromProps(specs);
specs = addDefaultPropsAndSockets(specs);
Expand All @@ -86,14 +85,20 @@ export async function generateSiSpecs(
// don't generate input sockets until we have all of the output sockets
specs = createInputSocketsBasedOnOutputSockets(specs);
specs = prettifySocketNames(specs);
// remove these after socket generation so we can still connect to their
// alternatives
specs = removeUnneededAssets(specs);

// Our overrides right now only run after the prop tree and the sockets are generated
specs = assetSpecificOverrides(specs);

// prune assets that cannot be created by cloud control and must be create
// using cf
specs = pruneCfAssets(specs);

// These need everything to be complete
specs = generateAssetFuncs(specs);
specs = updateSchemaIdsForExistingSpecs(existing_specs, specs);
specs = addSignatureToCategoryName(specs);

// WRITE OUTS SPECS
await emptyDirectory(SI_SPEC_DIR);
Expand Down
23 changes: 0 additions & 23 deletions bin/clover/src/pipeline-steps/addSignatureToCategoryName.ts

This file was deleted.

18 changes: 0 additions & 18 deletions bin/clover/src/pipeline-steps/ignoreSpecsWithoutHandlers.ts

This file was deleted.

Loading