Merge pull request #22 from tappeddev/validate_on_new_input

fix pipeline
tappeddev · Jul 11, 2024 · 482633e · 482633e
2 parents a13c9eb + d133d19
commit 482633e
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 22 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -10,39 +10,48 @@ concurrency:
 jobs:
   analyze:
     timeout-minutes: 5
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
-    - uses: actions/checkout@v3
-    - uses: kuhnroyal/flutter-fvm-config-action@v2
-      id: fvm-config-action
-    - uses: subosito/flutter-action@v2
-    - name: Get all dependencies
-      run: flutter pub get
-    - name: analyze app
-      run: flutter analyze
+      - uses: actions/checkout@v3
+      - uses: kuhnroyal/flutter-fvm-config-action@v2
+        id: fvm-config-action
+      - uses: subosito/flutter-action@v2
+        with:
+          flutter-version: ${{ env.FLUTTER_VERSION }}
+          channel: ${{ env.FLUTTER_CHANNEL }}
+      - name: Get all dependencies
+        run: flutter pub get
+      - name: analyze app
+        run: flutter analyze
 
   format:
     timeout-minutes: 5
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
-    - uses: actions/checkout@v3
-    - uses: kuhnroyal/flutter-fvm-config-action@v2
-      id: fvm-config-action
-    - uses: subosito/flutter-action@v2
-    - name: Get all dependencies
-      run: flutter pub get
-    - name: Check formatting
-      run: find . -name "*.dart" ! -name "*.g.dart" ! -name "*.freezed.dart" ! -path '*/generated/*' ! -path '*/gen/*' | xargs flutter format -n --set-exit-if-changed
+      - uses: actions/checkout@v3
+      - uses: kuhnroyal/flutter-fvm-config-action@v2
+        id: fvm-config-action
+      - uses: subosito/flutter-action@v2
+        with:
+          flutter-version: ${{ env.FLUTTER_VERSION }}
+          channel: ${{ env.FLUTTER_CHANNEL }}
+      - name: Get all dependencies
+        run: flutter pub get
+      - name: Check formatting
+        run: dart format -o none --set-exit-if-changed $(find . -name '*.dart' ! -name '*.g.dart' ! -name '*.freezed.dart' ! -path '*/generated/*' ! -path '*/gen/*')
 
   test:
     timeout-minutes: 5
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v3
       - uses: kuhnroyal/flutter-fvm-config-action@v2
         id: fvm-config-action
       - uses: subosito/flutter-action@v2
+        with:
+          flutter-version: ${{ env.FLUTTER_VERSION }}
+          channel: ${{ env.FLUTTER_CHANNEL }}
       - name: Get all dependencies
         run: flutter pub get
-      - name: Check formatting
+      - name: run tests
         run: flutter test
diff --git a/example/lib/main.dart b/example/lib/main.dart
@@ -37,7 +37,8 @@ class _ExampleAppState extends State<ExampleApp> {
                       onChanged: (value) {
                         setState(() => _text = value);
                       },
-                      decoration: const InputDecoration(label: Text("Enter some text")),
+                      decoration:
+                          const InputDecoration(label: Text("Enter some text")),
                       textStyle: const TextStyle(),
                       validator: (input) {
                         if (input == null || input.isEmpty) {

diff --git a/lib/src/custom_drop_down/custom_drop_down.dart b/lib/src/custom_drop_down/custom_drop_down.dart
@@ -291,7 +291,7 @@ class CustomDropDownState<T> extends State<CustomDropDown<T>>
                   : null,
               item: widget.items[i],
             ),
-          ]
+          ],
         ],
       ),
     );
-Original file line number
+Diff line change
@@ Expand Up @@
                       : null,
                   item: widget.items[i],
                 ),
-              ]
+              ],
             ],
           ),
         );
@@ Expand Down @@