Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Skip build-docker-image during post-commit code-analysis since the docker image is already built in a previous job #16703

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

williamlyTT
Copy link
Contributor

Ticket

...

Problem description

code-analysis step in APC already has needs:build-docker-image-2204, so build-docker-image before clang-tidy can be skipped

What's changed

Added build-docker input to code-analysis with default:true ; set to false during APC.

Checklist

@williamlyTT williamlyTT requested a review from a team as a code owner January 13, 2025 22:50
@blozano-tt
Copy link
Contributor

@afuller-TT plz check when you have time

@@ -32,6 +43,7 @@ jobs:

clang-tidy:
needs: build-docker-image
if: always()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct that without this, if it detects that build-docker-image was skipped, then it would skip this one, too?

And with this, it will run it despite a 'missing dependency'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, without always() it will skip clang-tidy as well: https://github.com/tenstorrent/tt-metal/actions/runs/12757215275

@williamlyTT williamlyTT merged commit ab4e9b5 into main Jan 13, 2025
117 of 202 checks passed
@williamlyTT williamlyTT deleted the williamly/build-docker-once-in-code-analysis branch January 13, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants