Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Skip build-docker-image during post-commit code-analysis since the docker image is already built in a previous job #16703

Merged
merged 3 commits into from
Jan 13, 2025
Merged

#0: Skip build-docker-image during post-commit code-analysis since the docker image is already built in a previous job #16703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
802ad92
Add skip-build-docker-image to post-commit since the docker image is …
williamlyTT Jan 13, 2025
c389ed2
Change input to build-docker to be consistent with existing input in …
williamlyTT Jan 13, 2025
f85a1c2
Add if: always() so that clang-tidy isn't skipped
williamlyTT Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/all-post-commit-workflows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ jobs:
secrets: inherit
with:
os: ubuntu-22.04-amd64
build-docker: false
tt-train-cpp-unit-tests:
needs: build-artifact
secrets: inherit
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/code-analysis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ on:
required: false
type: boolean
default: false
build-docker:
required: false
type: boolean
default: true
description: "Build docker image"
workflow_dispatch:
inputs:
os:
Expand All @@ -21,9 +26,15 @@ on:
required: false
type: boolean
default: false
build-docker:
required: false
type: boolean
default: true
description: "Build docker image"

jobs:
build-docker-image:
if: ${{ inputs.build-docker == true }}
uses: ./.github/workflows/build-docker-artifact.yaml
secrets: inherit
with:
Expand All @@ -32,6 +43,7 @@ jobs:

clang-tidy:
needs: build-docker-image
if: always()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct that without this, if it detects that build-docker-image was skipped, then it would skip this one, too?

And with this, it will run it despite a 'missing dependency'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, without always() it will skip clang-tidy as well: https://github.com/tenstorrent/tt-metal/actions/runs/12757215275

env:
ARCH_NAME: wormhole_b0
runs-on:
Expand Down
Loading