Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enabled St Albans to query planning constraints #2434

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Nov 16, 2023

@jessicamcinchak
Copy link
Member Author

@@ -70,6 +70,7 @@ function Component(props: Props) {
"medway",
"newcastle",
"southwark",
"st-albans",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew we'd hit this GIS meme sooner or later 😅

image

This has made me realise that I used "stalbans" in infra code - I think if we switch it it might create a new CDN (and then they'll have to update CNAME records). We should aim to fix this when we renew their certs next year 👍

This is correct though - our team slug is "st-albans". Might be another pointer towards using db flags for these types of values?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think it's our team slug that is wrong and should be aligned to https://www.stalbans.gov.uk/ !

That has fewer consequences of updating immediately I think since service URLs aren't live yet?

But, yes, db flag for toggling constraints is the way forward here - I'll add a column tomorrow!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I think the slug is fine to update as they aren't advertising the editor.planx.uk links anywhere - we might just need to cross check and update thinks like any links we have in Notion.

Copy link

github-actions bot commented Nov 16, 2023

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak merged commit 6958d88 into main Nov 16, 2023
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/gis-st-albans branch November 16, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants