Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enabled St Albans to query planning constraints #2434

Merged
merged 1 commit into from
Nov 16, 2023
Merged

feat: enabled St Albans to query planning constraints #2434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions editor.planx.uk/src/@planx/components/PlanningConstraints/Public.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ function Component(props: Props) {
"medway",
"newcastle",
"southwark",
"st-albans",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew we'd hit this GIS meme sooner or later 😅

image

This has made me realise that I used "stalbans" in infra code - I think if we switch it it might create a new CDN (and then they'll have to update CNAME records). We should aim to fix this when we renew their certs next year 👍

This is correct though - our team slug is "st-albans". Might be another pointer towards using db flags for these types of values?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think it's our team slug that is wrong and should be aligned to https://www.stalbans.gov.uk/ !

That has fewer consequences of updating immediately I think since service URLs aren't live yet?

But, yes, db flag for toggling constraints is the way forward here - I'll add a column tomorrow!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I think the slug is fine to update as they aren't advertising the editor.planx.uk links anywhere - we might just need to cross check and update thinks like any links we have in Notion.

];

const digitalLandParams: Record<string, string> = {
Expand Down
Loading