-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cryptoki via UNIX socket #3421
Draft
Bravo555
wants to merge
9
commits into
thin-edge:main
Choose a base branch
from
Bravo555:feat/hsm/unix-socket
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+412
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! |
307d71e
to
0bbbb1c
Compare
11 tasks
For rustls we have `default-features = false` because we don't want to use aws-lc-rs, but it also disabled other default features: `std` and `tls12`. These features have been reenabled. Feature determination scheme appears to be wonky as when I started working on p11 server, rustls screamed at me about `ClientConfig::builder` not existing. Indeed it requires `rustls/std` feature, but it worked fine before. Signed-off-by: Marcel Guzik <[email protected]>
This new version exposes `SingleKeyAndCert` resolver that we can use to remove some code. Signed-off-by: Marcel Guzik <[email protected]>
The resolver doesn't do anything PKCS#11 specific and can be trivially replaced with rustls `SingleKeyAndCert` resolver. Signed-off-by: Marcel Guzik <[email protected]>
Signed-off-by: Marcel Guzik <[email protected]>
Signed-off-by: Marcel Guzik <[email protected]>
0bbbb1c
to
0cdce00
Compare
0cdce00
to
95b71f4
Compare
Signed-off-by: Marcel Guzik <[email protected]>
95b71f4
to
064a7fe
Compare
Robot Results
Failed Tests
|
Signed-off-by: Marcel Guzik <[email protected]>
We use tedge-config as a fallback if the PKCS#11 module path and pin are not provided via cli, but as this service is going to run on the host without the rest of thin-edge, the config will probably also be absent, so it's not going to be that useful! Signed-off-by: Marcel Guzik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft notes
Current prototype allows signing via UNIX socket work, but it's limited to ECDSA P256 key.
In the current implementation phase, there are two types of requests that we have to worry about:
We'll have to ser/deserialize it and use some protocol for transferring it.
In the interest of keeping making the review faster, it would probably be good to keep this and following commits relatively small, so creation of new tedge service and calling it from tedge CLI and the mapper may be split.
Proposed changes
Types of changes
Paste Link to the issue
#3363
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments