-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Toit patches onto 5.3.1 #95
Conversation
👋 Hello floitsch, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
* cmpctmalloc: Protect MIN and MAX macros. These are defined in $HOME/.espressif/tools/riscv32-esp-elf/esp-2022r1-11.2.0/riscv32-esp-elf/riscv32-esp-elf/sys-include/sys/param.h causing a warning when defining them in cmpctmalloc.c. * feedback
This was introduced at some point, but it causes a linking error when trying to use the weak linking of start_cpu0 to run early init code as documented at https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/startup.html
Co-authored-by: Kasper Lund <[email protected]>
6d5c7bb
to
7799bbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good!
7799bbb
to
e60edc2
Compare
No description provided.