Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite): make sure that the DeviceAuthenticity overlay overlaps th… #17449

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

vojtatranta
Copy link
Contributor

…e sidebar too

Description

Related Issue

Resolve https://satoshilabs.slack.com/archives/C07CPLU4SE8/p1741015928984589

Screenshots:

@vojtatranta vojtatranta requested a review from jvaclavik March 6, 2025 14:28
@vojtatranta vojtatranta self-assigned this Mar 6, 2025
Copy link
Contributor

@jvaclavik jvaclavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it doesn't break anything 😅

@@ -23,7 +23,6 @@ import { LoggedOutSidebar } from '../LoggedOutSidebar';

const Content = styled.div<{ $elevation: Elevation }>`
display: flex;
position: relative;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really not sure about this, but it works.

Basically, there is a two column layout on the welcome screen. And we want to right column with the content that has position: absolute to overlap to the left column.

Before, there was a different left column that was a Trezor logo which we didn't wanted it to be overlayed.
So this might make sense.

@vojtatranta vojtatranta marked this pull request as ready for review March 6, 2025 14:46
Copy link

coderabbitai bot commented Mar 6, 2025

Walkthrough

The pull request removes the position: relative; CSS property from the Content styled component within the WelcomeLayout.tsx file. This change modifies the layout behavior of the Content flex container by altering how its child elements are positioned relative to each other. There are no other modifications made to the component's logic, error handling, control flow, or declarations of exported or public entities.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83808a4 and 6fc0207.

📒 Files selected for processing (1)
  • packages/suite/src/components/suite/layouts/WelcomeLayout/WelcomeLayout.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/suite/src/components/suite/layouts/WelcomeLayout/WelcomeLayout.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jvaclavik jvaclavik merged commit 6d3aa29 into develop Mar 6, 2025
29 checks passed
@jvaclavik jvaclavik deleted the fix-zindex-welcom-nav branch March 6, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

2 participants