-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(suite): make sure that the DeviceAuthenticity overlay overlaps th… #17449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope it doesn't break anything 😅
@@ -23,7 +23,6 @@ import { LoggedOutSidebar } from '../LoggedOutSidebar'; | |||
|
|||
const Content = styled.div<{ $elevation: Elevation }>` | |||
display: flex; | |||
position: relative; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really not sure about this, but it works.
Basically, there is a two column layout on the welcome screen. And we want to right column with the content that has position: absolute
to overlap to the left column.
Before, there was a different left column that was a Trezor logo which we didn't wanted it to be overlayed.
So this might make sense.
WalkthroughThe pull request removes the 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…e sidebar too
Description
Related Issue
Resolve https://satoshilabs.slack.com/archives/C07CPLU4SE8/p1741015928984589
Screenshots: