Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite): make sure that the DeviceAuthenticity overlay overlaps th… #17449

Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix(suite): make sure that the DeviceAuthenticity overlay overlaps th… #17449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/suite/src/components/suite/layouts/WelcomeLayout/WelcomeLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { LoggedOutSidebar } from '../LoggedOutSidebar';

const Content = styled.div<{ $elevation: Elevation }>`
display: flex;
position: relative;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really not sure about this, but it works.

Basically, there is a two column layout on the welcome screen. And we want to right column with the content that has position: absolute to overlap to the left column.

Before, there was a different left column that was a Trezor logo which we didn't wanted it to be overlayed.
So this might make sense.

flex-direction: column;
flex: 3;
padding: ${spacingsPx.lg};
Expand Down