Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to override publishing options #104

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

roback
Copy link
Member

@roback roback commented Dec 12, 2023

This lets the TopicExchangePublisher#publish method override the previously set routing_key, which makes it possible to publish messages having different routing keys.

This also enables us to set all other publishing options per message, which before were only possible to change by reconfiguring the publisher.

Close #60

This lets the TopicExchangePublisher#publish method override the
previously set routing_key, which makes it possible to publish
messages having different routing keys.

This also enables us to set [all other publishing options][1] per
message, which before were only possible to change by reconfiguring
the publisher.

Close #60

[1]: https://www.rubydoc.info/github/ruby-amqp/bunny/Bunny/Exchange#publish-instance_method
@roback roback self-assigned this Dec 12, 2023
Copy link
Contributor

@vikiv480 vikiv480 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@roback roback merged commit c1348d3 into master Dec 13, 2023
8 checks passed
@roback roback deleted the issue/60/override-routing-key branch December 13, 2023 10:43
roback added a commit that referenced this pull request Dec 13, 2023
Because of the new feature that was added in #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let TopicExchangePublisher#publish accept routing_key
2 participants