fix: duplicate_package_checker panic when package.json has no version field

[sorrycc]

Close #1632

Summary by CodeRabbit

• Bug Fixes

  • 改进了重复包检查插件的版本解析，增强了代码的健壮性，避免了因解析失败导致的运行时错误。

• Style

  • 进行了轻微的格式调整。

[coderabbitai]

Walkthrough

本次更改对 crates/mako/src/plugins/duplicate_package_checker.rs 文件中的 DuplicatePackageCheckerPlugin 结构体的 check_duplicates 方法进行了修改。主要改动是对 package_json 中 version 的提取处理，之前直接在 PackageInfo 的结构体实例化中解析 version，可能导致解析失败时的恐慌。新实现首先尝试解析 version，并通过条件语句检查解析是否成功，只有在成功时才创建 PackageInfo 实例并将其推入 packages 向量中。此更改增强了代码的健壮性，防止因版本解析失败而导致的运行时错误。

Changes

文件路径	更改摘要
crates/mako/src/plugins/duplicate_package_checker.rs	修改 check_duplicates 方法，增强 version 解析的健壮性，避免解析失败导致的恐慌。

Assessment against linked issues

Objective	Addressed	Explanation
解决异步函数代码中的错误恐慌问题 (#1632)	✅

Possibly related PRs

• feat: #1491 add duplicate package checker plugin #1496: 此 PR 引入了 DuplicatePackageCheckerPlugin，与本次 PR 中对同一插件实现的 check_duplicates 方法的修改直接相关，均旨在增强重复包检查的功能和健壮性。

Poem

在兔子洞里跳跃欢，
版本解析不再难。
错误恐慌已远去，
包裹信息稳如山。
兔子欢呼声声响，
代码健壮乐无边。 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

crates/mako/src/plugins/duplicate_package_checker.rs (1)

106-114: 版本解析逻辑改进，但可以考虑添加错误日志

这个改动很好地解决了当 package.json 中缺少版本字段时的崩溃问题。通过在创建 PackageInfo 实例之前检查版本解析是否成功，代码变得更加健壮。

建议：
考虑在版本解析失败时添加一条警告日志，以便于调试和问题追踪。例如：

if let Ok(version) = version {
    let package_info = PackageInfo {
        name,
        version,
        path: package_json.path.clone(),
    };
    packages.push(package_info);
} else {
    log::warn!("Failed to parse version for package: {}", name);
}

这样可以在不中断程序执行的情况下，为开发者提供有用的调试信息。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 5c79eb9 and dafe36b.

📒 Files selected for processing (1)

• crates/mako/src/plugins/duplicate_package_checker.rs (1 hunks)

🧰 Additional context used

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.67%. Comparing base (5c79eb9) to head (dafe36b).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1634   +/-   ##
=======================================
  Coverage   55.66%   55.67%           
=======================================
  Files         172      172           
  Lines       17294    17296    +2     
=======================================
+ Hits         9627     9629    +2     
  Misses       7667     7667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.