Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicate_package_checker panic when package.json has no version field #1634

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: duplicate_package_checker panic when package.json has no version field #1634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions crates/mako/src/plugins/duplicate_package_checker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,15 @@ impl DuplicatePackageCheckerPlugin {
let raw_json = package_json.raw_json();
if let Some(name) = package_json.name.clone() {
if let Some(version) = raw_json.as_object().unwrap().get("version") {
let package_info = PackageInfo {
name,
version: semver::Version::parse(version.as_str().unwrap())
.unwrap(),
path: package_json.path.clone(),
};

packages.push(package_info);
let version = semver::Version::parse(version.as_str().unwrap());
if let Ok(version) = version {
let package_info = PackageInfo {
name,
version,
path: package_json.path.clone(),
};
packages.push(package_info);
}
}
}
}
Expand Down
Loading