-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor setup.py: #114
base: master
Are you sure you want to change the base?
Refactor setup.py: #114
Conversation
@mindw: thanks, you make some good suggestions. This is a big patch, so I'll have to come back to it when I can fully review it (i.e. soon, but not immediately). |
Sure. |
rebased. |
thanks for keeping it on the radar. |
cf7d1b9
to
025bdbb
Compare
👍 on this. I envision a hard time advocating this to my team with so horribly unconventional setup script. 😃 |
025bdbb
to
c518d08
Compare
non dead yet :) |
- tuple, list, dict, file, buffer, builtin, | ||
- both old and new style classes, | ||
- instances of old and new style classes, | ||
- set, frozenset, array, functions, exceptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This no longer renders as a list but as a code block.
|
||
The latest released version of `dill` is available from:: | ||
|
||
http://trac.mystic.cacr.caltech.edu/project/pathos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to make these links clickable, probably by dedenting.
|
||
You can get the latest development version with all the shiny new features at:: | ||
|
||
https://github.com/uqfoundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A URL to dill specifically would be nice.
|
||
The latest released version of `dill` is available from:: | ||
|
||
http://trac.mystic.cacr.caltech.edu/project/pathos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to make these links clickable, probably by dedenting.
Optional requirements:: | ||
|
||
- setuptools, version >= 0.6 | ||
- objgraph, version >= 1.7.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also consider making these items a list.
Current Release | ||
=============== | ||
|
||
This version is `dill-%(relver)s`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is relver
interpolated somewhere? Additionally, it won't show updated on PyPI which reads raw README.rst.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed line (was never part of the original README).
license = '3-clause BSD', | ||
platforms = ['Linux', 'Windows', 'Mac'], | ||
url = 'http://www.cacr.caltech.edu/~mmckerns/dill.htm', | ||
download_url = 'http://dev.danse.us/packages', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
404 + redundant.
maintainer_email = 'mmckerns at uqfoundation dot org', | ||
license = '3-clause BSD', | ||
platforms = ['Linux', 'Windows', 'Mac'], | ||
url = 'http://www.cacr.caltech.edu/~mmckerns/dill.htm', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to link to http://trac.mystic.cacr.caltech.edu/project/pathos/wiki/dill.html directly.
maintainer = 'Mike McKerns', | ||
maintainer_email = 'mmckerns at uqfoundation dot org', | ||
license = '3-clause BSD', | ||
platforms = ['Linux', 'Windows', 'Mac'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant.
|
||
install_requires = [] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be inlined?
@kernc: unconventional? FYI, it was a common way to do it at least some years ago, and was standardly used by the likes of @mindw & @kernc: there may be some changes that I'm not sure that I want, but several of them I know already should go in. I'm fine with taking a piecemeal approach to this PR as I go through it, if you are. |
Corrected review comments. @mmckerns , as you see fit :) |
@mindw Maybe you could rebase again... Just to make Travis happy. 😜 |
* use entry_points * build universal wheels * use setuptools_scm for version tracking * eliminate readme duplication by dropping README.md * use manifest.in * add .gitignore
1ad8545
to
c46e755
Compare
rebased. |
* remove outdated Python versions (2.5, 3.1, 3.2) * make sure pip & setuptools are up to date
Any updates on this? |
@shuttle1987: no not yet. |
Good news! Since the new PyPI (aka Warehouse) launched, it's now possible to use Markdown directly as the See these instructions and example: |
For your consideration.