-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating logos #1919
updating logos #1919
Conversation
I need to update the favicon, just a moment |
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Favicon updated, I think that's everything. |
de58b80
to
9e3a72c
Compare
May need to force a refresh to get the favicon to update in the preview |
@deepthi, should we use the stacked logo on the splash page? |
Stacked may work better if we had a color-icon/white-text version |
Let's not use a stacked logo right now
I'll open a separate issue for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything missing.
Can we drop the background image? It doesn't go well with the new logo.
Unrelated, we should also open an issue to remove all the |
We can try it -- I'd suggest replacing it with something though, that image helps break the page into sections. Maybe it needs a new color scheme? |
Created #1920 to follow up with more changes |
May take me a bit to do the background -- maybe we add the background to the follow up too? |
@nate-double-u if that's OK with you, we can push the one change to change that landing page logo background image. |
Hey @nate-double-u! Could we just drop the bg and change the hero class to |
aaa8238
to
7e19c1b
Compare
Haha, we're all commenting at the same time 😅 . Apologies for the noise @nate-double-u ! Seeing that this PR comes from your own fork we obviously can't push. I'm deferring to whatever you and @hollylawly see fit. |
Agreed @hollylawly, good suggestion. I've removed it. |
I feel like i should be streaming 😜 (it's great seeing folks interested! I really like this new logo) |
I went with the |
Thank you @nate-double-u ! On our side we prefer EDIT as I'm writing this you've already deployed that change ❤️ You mentioned your bandwidth is limited for now so we don't want to burden you much further. Our design team will want to spend some time re-evaluating some colors. If that's all right, we'll take a few days to check it out and propose a change. We'll CC you on the PR for review. Thank you! |
I like the latest version: light background with the stacked logo the best of all the options. The icon in the logo isn't enough to not have the Vitess name IMO |
OK, i'll push the light change with the stacked logo, and I missed removing the back ground from the footer -- I'll do that now too. |
I think there are some knock'on effects of changing the footer -- probably best to add it to the #1920 follow up as a part of the re-skin. |
Signed-off-by: Nate W <[email protected]>
47b022e
to
4cfe675
Compare
we can merge this without fixing the "Documentation" issue and fix that later. @nate-double-u WDYT? If you agree, please go ahead and push the button. I can add it as a task to #1920 |
Good catch, but i think it's probably better to get this in as is to bring all the logos across the ecosystem back into agreement. |
Thanks for all the feedback everyone, I'll merge this as is. |
Thanks a bunch @nate-double-u! I've updated #1920 to reflect the latest gaps with this PR merged. |
Thank you so much @nate-double-u! Came out great ❤️ |
Adding new logos from cncf/artwork#521 (comment)
fixes #1918