Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating logos #1919

Merged
merged 1 commit into from
Jan 14, 2025
Merged

updating logos #1919

merged 1 commit into from
Jan 14, 2025

Conversation

nate-double-u
Copy link
Collaborator

Adding new logos from cncf/artwork#521 (comment)

fixes #1918

@nate-double-u
Copy link
Collaborator Author

I need to update the favicon, just a moment

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 4cfe675
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/6786b96eaf17c10008072499
😎 Deploy Preview https://deploy-preview-1919--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nate-double-u
Copy link
Collaborator Author

Favicon updated, I think that's everything.

@nate-double-u nate-double-u force-pushed the update-logos branch 2 times, most recently from de58b80 to 9e3a72c Compare January 14, 2025 18:25
@nate-double-u
Copy link
Collaborator Author

nate-double-u commented Jan 14, 2025

May need to force a refresh to get the favicon to update in the preview

@nate-double-u
Copy link
Collaborator Author

@deepthi, should we use the stacked logo on the splash page?

@nate-double-u
Copy link
Collaborator Author

Screenshot 2025-01-14 at 10 33 09 AM Screenshot 2025-01-14 at 10 32 58 AM

@nate-double-u
Copy link
Collaborator Author

nate-double-u commented Jan 14, 2025

Stacked may work better if we had a color-icon/white-text version

@deepthi
Copy link
Member

deepthi commented Jan 14, 2025

Let's not use a stacked logo right now

  • You are exactly right that we'd need white text for stacking
  • The font doesn't match

I'll open a separate issue for this.

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything missing.
Can we drop the background image? It doesn't go well with the new logo.

@nate-double-u
Copy link
Collaborator Author

Unrelated, we should also open an issue to remove all the .DS_Store files and add it to the .gitignore. They're macos system files and shouldn't be in the repo.

@nate-double-u
Copy link
Collaborator Author

Can we drop the background image? It doesn't go well with the new logo.

We can try it -- I'd suggest replacing it with something though, that image helps break the page into sections. Maybe it needs a new color scheme?

@deepthi
Copy link
Member

deepthi commented Jan 14, 2025

Created #1920 to follow up with more changes

@nate-double-u
Copy link
Collaborator Author

May take me a bit to do the background -- maybe we add the background to the follow up too?

@shlomi-noach
Copy link
Contributor

@nate-double-u if that's OK with you, we can push the one change to change that landing page logo background image.

@hollylawly
Copy link

Hey @nate-double-u! Could we just drop the bg and change the hero class to is-dark for now if anything? I personally love how it looks with is-light background though if that's an option.
CleanShot 2025-01-14 at 11 39 27@2x

CleanShot 2025-01-14 at 11 37 00@2x

@shlomi-noach
Copy link
Contributor

Haha, we're all commenting at the same time 😅 . Apologies for the noise @nate-double-u ! Seeing that this PR comes from your own fork we obviously can't push. I'm deferring to whatever you and @hollylawly see fit.

@nate-double-u
Copy link
Collaborator Author

Agreed @hollylawly, good suggestion. I've removed it.

@nate-double-u
Copy link
Collaborator Author

Haha, we're all commenting at the same time 😅 . Apologies for the noise @nate-double-u ! Seeing that this PR comes from your own fork we obviously can't push. I'm deferring to whatever you and @hollylawly see fit.

I feel like i should be streaming 😜 (it's great seeing folks interested! I really like this new logo)

@nate-double-u
Copy link
Collaborator Author

go with is-light background though if that's an option

I went with the is-dark because of how it separates the sections. But I'll let you all come to an agreement -- it's totally feasable, and a quick change, so let me know

@nate-double-u
Copy link
Collaborator Author

nate-double-u commented Jan 14, 2025

Another option, light background with the stacked logo (it's OK that the font is different, it's the logo 🙂)

Screenshot 2025-01-14 at 11 03 29 AM Screenshot 2025-01-14 at 11 08 34 AM

@shlomi-noach
Copy link
Contributor

Thank you @nate-double-u ! On our side we prefer is-light as it works better for the logo -- though I do see how you mean that the dark background helps dividing the landing page. Let's switch to light for now.

EDIT as I'm writing this you've already deployed that change ❤️

You mentioned your bandwidth is limited for now so we don't want to burden you much further. Our design team will want to spend some time re-evaluating some colors. If that's all right, we'll take a few days to check it out and propose a change. We'll CC you on the PR for review.

Thank you!

@derekperkins
Copy link
Member

I like the latest version: light background with the stacked logo the best of all the options. The icon in the logo isn't enough to not have the Vitess name IMO

@nate-double-u
Copy link
Collaborator Author

OK, i'll push the light change with the stacked logo, and I missed removing the back ground from the footer -- I'll do that now too.

@nate-double-u
Copy link
Collaborator Author

nate-double-u commented Jan 14, 2025

I think there are some knock'on effects of changing the footer -- probably best to add it to the #1920 follow up as a part of the re-skin.

Signed-off-by: Nate W <[email protected]>
@shlomi-noach shlomi-noach self-requested a review January 14, 2025 19:43
@deepthi
Copy link
Member

deepthi commented Jan 14, 2025

There's a problem with the light background. See how the "Documentation" blends in with no box around it?
Screenshot 2025-01-14 at 11 42 12 AM

@deepthi
Copy link
Member

deepthi commented Jan 14, 2025

we can merge this without fixing the "Documentation" issue and fix that later. @nate-double-u WDYT? If you agree, please go ahead and push the button. I can add it as a task to #1920

@nate-double-u
Copy link
Collaborator Author

There's a problem with the light background. See how the "Documentation" blends in with no box around it?

Good catch, but i think it's probably better to get this in as is to bring all the logos across the ecosystem back into agreement.

@nate-double-u
Copy link
Collaborator Author

Thanks for all the feedback everyone, I'll merge this as is.

@nate-double-u nate-double-u merged commit 6bb41b3 into vitessio:prod Jan 14, 2025
5 checks passed
@nate-double-u nate-double-u deleted the update-logos branch January 14, 2025 19:53
@deepthi
Copy link
Member

deepthi commented Jan 14, 2025

Thanks a bunch @nate-double-u! I've updated #1920 to reflect the latest gaps with this PR merged.

@hollylawly
Copy link

Thank you so much @nate-double-u! Came out great ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update website with new logos
5 participants