-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Take 2] Remove YAML; add disclosures to SD-JWT examples; add protected headers #273
Conversation
have fixed rendering and believe it to be correct. please review cc: @bc-pi @selfissued |
@bc-pi unfortunately...that is correct given the usage of the Enveloped type this was a ... compromise to include vc-jose-cose secured credentials in presentations. see relevant discussion:
I agree it's ugly. I'd like to see us continue to discuss improving the envelope types in a follow-up issue. I hope this PR at least makes the examples clearer. |
merging as this just fixes examples and is purely editorial |
The tabs do help, thanks. However, (and limiting the commentary to just the scope of this now merged PR) the listing of the value of the claim after "Claim:" under the "Issuer Disclosures" tab rather than the claim name seems incorrect and unhelpful. And makes the aforementioned ugliness more prominent than need be. |
thank you @bc-pi I agree that it's confusing. I fixed this in #274 - which you should now see reflected here https://w3c.github.io/vc-jose-cose/#securing-json-ld-verifiable-credentials-with-sd-jwt |
Thanks @decentralgabe ! |
Fix #269 and replaces #270
Fix #271
Fix #264
Preview | Diff