Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#951) μŒμ•… 상세 νŽ˜μ΄μ§€ λ””μžμΈ μˆ˜μ • #960

Merged
merged 4 commits into from
Aug 2, 2024
Merged

πŸ”€ :: (#951) μŒμ•… 상세 νŽ˜μ΄μ§€ λ””μžμΈ μˆ˜μ • #960

merged 4 commits into from
Aug 2, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Aug 2, 2024

πŸ’‘ λ°°κ²½ 및 κ°œμš”

  • μŒμ•… 상세 λ””μžμΈ μˆ˜μ •

Resolves: #951

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • μŒμ•… 상세 νŽ˜μ΄μ§€μ˜ λ””μžμΈκ³Ό μΌμΉ˜ν•˜μ§€ μ•ŠλŠ” 뢀뢄을 ν•΄κ²°ν–ˆμ–΄μš”
  • μŒμ•… 상세 νŽ˜μ΄μ§€μ— 있던 였λ₯˜λ₯Ό ν•΄κ²°ν–ˆμ–΄μš”

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@baekteun baekteun linked an issue Aug 2, 2024 that may be closed by this pull request
μŒμ•… 상세 νŽ˜μ΄μ§€ UI μˆ˜μ • #951
Closed
@github-actions github-actions bot added the 1️⃣ Priority: High μš°μ„ μˆœμœ„ 상 label Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun

@baekteun baekteun merged commit 467e7b8 into develop Aug 2, 2024
5 checks passed
@baekteun baekteun deleted the 951-music-detail-ui-design branch August 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@youn9k youn9k youn9k approved these changes

@yongbeomkwak yongbeomkwak Awaiting requested review from yongbeomkwak yongbeomkwak is a code owner

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

Assignees

@baekteun baekteun

Labels
1️⃣ Priority: High μš°μ„ μˆœμœ„ 상
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

μŒμ•… 상세 νŽ˜μ΄μ§€ UI μˆ˜μ •
3 participants
@baekteun @KangTaeHoon @youn9k