Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”€ :: (#951) μŒμ•… 상세 νŽ˜μ΄μ§€ λ””μžμΈ μˆ˜μ • #960

Merged
merged 4 commits into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ final class MusicDetailReactor: Reactor {
case .playListButtonDidTap:
return playListButtonDidTap()
case .dismissButtonDidTap:
return .just(.navigate(.dismiss))
return navigateMutation(navigate: .dismiss)
}
}

Expand Down Expand Up @@ -179,10 +179,7 @@ private extension MusicDetailReactor {
)
LogManager.analytics(log)
}
return .concat(
.just(.navigate(.youtube(id: song.videoID))),
.just(.navigate(nil))
)
return navigateMutation(navigate: .youtube(id: song.videoID))
}

func nextButtonDidTap() -> Observable<Mutation> {
Expand Down Expand Up @@ -219,17 +216,14 @@ private extension MusicDetailReactor {
title: song.title,
artist: song.artistString
)
return .concat(
.just(.navigate(.lyricsHighlighting(model: lyricHighlightingModel))),
.just(.navigate(nil))
)
return navigateMutation(navigate: .lyricsHighlighting(model: lyricHighlightingModel))
}

func creditButtonDidTap() -> Observable<Mutation> {
guard let song = currentState.selectedSong else { return .empty() }
let log = Log.clickCreditButton(id: song.videoID)
LogManager.analytics(log)
return .just(.navigate(.credit(id: song.videoID)))
return navigateMutation(navigate: .credit(id: song.videoID))
}

func likeButtonDidTap() -> Observable<Mutation> {
Expand Down Expand Up @@ -269,34 +263,35 @@ private extension MusicDetailReactor {
guard let song = currentState.selectedSong else { return .empty() }
let log = Log.clickMusicPickButton(id: song.videoID)
LogManager.analytics(log)
return .concat(
.just(.navigate(.musicPick(id: song.videoID))),
.just(.navigate(nil))
)
return navigateMutation(navigate: .musicPick(id: song.videoID))
}

func playListButtonDidTap() -> Observable<Mutation> {
guard let song = currentState.selectedSong else { return .empty() }
let log = Log.clickPlaylistButton(id: song.videoID)
LogManager.analytics(log)
return .concat(
.just(.navigate(.playlist)),
.just(.navigate(nil))
)
return navigateMutation(navigate: .playlist)
}
}

// MARK: - Private Methods

private extension MusicDetailReactor {
func navigateMutation(navigate: NavigateType) -> Observable<Mutation> {
return .concat(
.just(.navigate(navigate)),
.just(.navigate(nil))
)
}

func prefetchThumbnailImage(index: Int) {
if let songID = currentState.songIDs[safe: index],
let thumbnailPrefetchingSongID = currentState.songDictionary[songID]?.videoID,
let thumbnailURL = URL(
string: youtubeURLGenerator.generateHDThumbnailURL(id: thumbnailPrefetchingSongID)
) {
ImagePrefetcher(urls: [thumbnailURL]).start()
}
let prefetchingSongImageURLs = [
currentState.songIDs[safe: index - 1],
currentState.songIDs[safe: index],
currentState.songIDs[safe: index + 1]
].compactMap { $0 }
.compactMap { URL(string: youtubeURLGenerator.generateHDThumbnailURL(id: $0)) }
ImagePrefetcher(urls: prefetchingSongImageURLs).start()
}

func fetchSongDetailWith(index: Int) -> Observable<Mutation> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ private extension MusicDetailView {

func setLayout() {
thumbnailCollectionView.snp.makeConstraints {
$0.top.lessThanOrEqualTo(self.safeAreaLayoutGuide.snp.top).offset(52)
$0.top.lessThanOrEqualTo(wmNavigationbarView.snp.bottom).offset(44)
$0.centerX.equalToSuperview()
$0.leading.trailing.equalToSuperview()
$0.height.equalTo(thumbnailCollectionView.snp.width).multipliedBy(9.0 / 16.0)
Expand All @@ -148,7 +148,7 @@ private extension MusicDetailView {
wmNavigationbarView.setRightViews([creditButton])

musicControlView.snp.makeConstraints {
$0.top.equalTo(thumbnailCollectionView.snp.bottom).offset(36)
$0.top.equalTo(thumbnailCollectionView.snp.bottom).offset(20).priority(.required)
$0.leading.trailing.equalToSuperview().inset(36)
$0.bottom.lessThanOrEqualTo(musicToolbarView.snp.top)
$0.height.equalTo(musicControlView.snp.width).multipliedBy(1.0 / 1.0)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,39 +20,21 @@ final class MusicHeartButton: VerticalAlignButton {
}

func setIsLike(isLike: Bool, animated: Bool = true) {
let heartImage: UIImage
if isLike {
heartImage = DesignSystemAsset.MusicDetail.heartFill.image
let heartImage: UIImage = if isLike {
DesignSystemAsset.MusicDetail.heartFill.image
} else {
heartImage = DesignSystemAsset.MusicDetail.heart.image
}

self.isLike = isLike
guard animated else {
self.setImage(heartImage, for: .normal)
self.setIsLikeTextColor(isLike: isLike)
return
}

self.imageView?.transform = .init(scaleX: 1.25, y: 1.25)
UIViewPropertyAnimator(duration: 0.3, curve: .easeIn) {
self.imageView?.transform = .identity
DesignSystemAsset.MusicDetail.heart.image
}
.startAnimation()

self.setImage(heartImage, for: .normal)
self.setIsLikeTextColor(isLike: isLike)
}

private func setIsLikeTextColor(isLike: Bool) {
if isLike {
self.setTitleColor(DesignSystemAsset.PrimaryColorV2.increase.color, for: .normal)
self.setTitleColor(DesignSystemAsset.PrimaryColorV2.increase.color, for: .selected)
self.setTitleColor(DesignSystemAsset.PrimaryColorV2.increase.color, for: .highlighted)
self.setTextColor(color: DesignSystemAsset.PrimaryColorV2.increase.color)
} else {
self.setTitleColor(DesignSystemAsset.NewGrayColor.gray400.color, for: .normal)
self.setTitleColor(DesignSystemAsset.NewGrayColor.gray400.color, for: .selected)
self.setTitleColor(DesignSystemAsset.NewGrayColor.gray400.color, for: .highlighted)
self.setTextColor(color: DesignSystemAsset.NewGrayColor.gray400.color)
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,15 @@ extension MusicToolbarView: MusicToolbarStateProtocol {

func updateIsLike(likes: Int, isLike: Bool) {
heartButton.setTitle("\(likes.toUnitNumber)", for: .normal)
heartButton.setIsLike(isLike: isLike)

// let textColor = isLike
// ? DesignSystemAsset.PrimaryColorV2.increase.color
// : DesignSystemAsset.NewGrayColor.gray400.color
// heartButton.setTitleColor(
// textColor,
// for: .normal
// )
heartButton.setIsLike(isLike: isLike, animated: false)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ private extension ThumbnailCell {

func setLayout() {
thumbnailImageView.snp.makeConstraints {
$0.top.bottom.equalToSuperview()
$0.leading.trailing.equalToSuperview().inset(24)
$0.center.equalToSuperview()
$0.height.equalTo(thumbnailImageView.snp.width).multipliedBy(9.0 / 16.0)
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,11 @@ final class PlaylistViewModel: ViewModelType {
})
.withLatestFrom(output.selectedSongIds) { selectedPlaylistItem, selectedSongIds in
var mutableSelectedSongIds = selectedSongIds
mutableSelectedSongIds.insert(selectedPlaylistItem.id)
if mutableSelectedSongIds.contains(selectedPlaylistItem.id) {
mutableSelectedSongIds.remove(selectedPlaylistItem.id)
} else {
mutableSelectedSongIds.insert(selectedPlaylistItem.id)
}
return mutableSelectedSongIds
}
.bind(to: output.selectedSongIds)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"images" : [
{
"filename" : "heart.fill.svg",
"filename" : "ic_32_heart_on.svg",
"idiom" : "universal"
}
],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"images" : [
{
"filename" : "heart.svg",
"filename" : "ic_32_heart_off.svg",
"idiom" : "universal"
}
],
Expand Down

This file was deleted.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"images" : [
{
"filename" : "ic_32_playadd_25.svg",
"filename" : "ic_32_playadd_400.svg",
"idiom" : "universal"
}
],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"images" : [
{
"filename" : "playlist.svg",
"filename" : "ic_32_play_list_400.svg",
"idiom" : "universal"
}
],
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"images" : [
{
"filename" : "views.svg",
"filename" : "ic_32_views.svg",
"idiom" : "universal"
}
],
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,14 @@ open class VerticalAlignButton: UIButton {
super.awakeFromNib()
self.contentHorizontalAlignment = .left
}

public func setTextColor(color: UIColor) {
self.configuration?.titleTextAttributesTransformer = UIConfigurationTextAttributesTransformer {
var attribute = $0
attribute.font = UIFont.setFont(.t7(weight: .medium))
attribute.foregroundColor = color
attribute.kern = -0.5
return attribute
}
}
}
Loading