Revert change to link-resolver #11548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gestchild
previously approved these changes
Jan 30, 2025
2 tasks
|
Size Change: -377 B (-0.04%) Total Size: 1.02 MB
ℹ️ View Unchanged
|
|
Just noticed the links on the bottom of this page, in the other exhibitions bit, don't work: |
gestchild
approved these changes
Jan 30, 2025
rcantin-w
changed the title
Merged
gestchild
pushed a commit
that referenced
this pull request
Feb 5, 2025
Revert change to link-resolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Flagged as a bug by Grace on Slack
This I think is due to a change we made for the search links to work as expected.
As that's still behind a toggle, I'm just reverting the change to the link on the exhibition guides page gets back to normal/working.
We can address the fix for the search component at a later point: #11549
UPDATE: To address other problems that were found, all changes to the link resolvers from the search work have been reverted, we'll address them in the ticket listed above.
How to test
Access exhibition texts from various points; is it fixed on what users see?
e.g. http://localhost:3000/guides/exhibitions/hard-graft
Do the links at the bottom (from the other exhibition) also work?
How can we measure success?
Not a broken link anymore
Have we considered potential risks?
I don't think it'll break anything other than the search results behind the toggle, but good to QA a few different places to make sure.