-
-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Story Aeneid chain #3354
Conversation
🦋 Changeset detectedLatest commit: fb52c91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@rasplarry is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
@@ -442,6 +442,7 @@ export { sophonTestnet } from './definitions/sophonTestnet.js' | |||
export { spicy } from './definitions/spicy.js' | |||
export { step } from './definitions/step.js' | |||
export { story } from './definitions/story.js' | |||
export { storyAeneid } from './definitions/storyAeneid.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the storyOdyssey
and storyTestnet
be removed? I believe this generates some confusion. The only testnet described currently in the docs is Aeneid - https://docs.story.foundation/docs/aeneid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understood storyOdyssey and storyTestnet are deprecated.
I added Aeneid because my app needs it, which means I’m not from Story.
I just saw that a previously closed (not merged) PR marked them as deprecated..
I’m not sure if I can remove them, so should I wait for the foundation to add the chain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning to do the same (i.e. add a PR with the Aeneid testnet), but I've noticed your PR ;)
I just belive that "by the way" the old testnets could be removed (to reduce the confusion among the users) - the Odyssey scanner does not even work anymore - https://odyssey.storyscan.xyz/
I can ask someone from the Story team for confirmation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you ask someone then?!
I'll remove it if it's confirmed. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I just added the @deprecated
mark, as the PR I mentioned above did before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing chains is a breaking change. They will be removed in the next major version.
Added story-aeneid