Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Story Aeneid chain #3354

Merged
merged 1 commit into from
Feb 17, 2025
Merged

feat: Add Story Aeneid chain #3354

merged 1 commit into from
Feb 17, 2025

Conversation

rasplarry
Copy link
Contributor

Added story-aeneid

Copy link

changeset-bot bot commented Feb 16, 2025

🦋 Changeset detected

Latest commit: fb52c91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 16, 2025

@rasplarry is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@@ -442,6 +442,7 @@ export { sophonTestnet } from './definitions/sophonTestnet.js'
export { spicy } from './definitions/spicy.js'
export { step } from './definitions/step.js'
export { story } from './definitions/story.js'
export { storyAeneid } from './definitions/storyAeneid.js'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the storyOdyssey and storyTestnet be removed? I believe this generates some confusion. The only testnet described currently in the docs is Aeneid - https://docs.story.foundation/docs/aeneid

Copy link
Contributor Author

@rasplarry rasplarry Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understood storyOdyssey and storyTestnet are deprecated.
I added Aeneid because my app needs it, which means I’m not from Story.
I just saw that a previously closed (not merged) PR marked them as deprecated..
I’m not sure if I can remove them, so should I wait for the foundation to add the chain?

Copy link

@ppedziwiatr ppedziwiatr Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to do the same (i.e. add a PR with the Aeneid testnet), but I've noticed your PR ;)

I just belive that "by the way" the old testnets could be removed (to reduce the confusion among the users) - the Odyssey scanner does not even work anymore - https://odyssey.storyscan.xyz/

I can ask someone from the Story team for confirmation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you ask someone then?!
I'll remove it if it's confirmed. Thank you!

Copy link
Contributor Author

@rasplarry rasplarry Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I just added the @deprecated mark, as the PR I mentioned above did before

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing chains is a breaking change. They will be removed in the next major version.

@jxom jxom merged commit eec264f into wevm:main Feb 17, 2025
2 of 3 checks passed
@github-actions github-actions bot mentioned this pull request Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants