Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Story Aeneid chain #3354

Merged
merged 1 commit into from
Feb 17, 2025
Merged

feat: Add Story Aeneid chain #3354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twenty-moons-bathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"viem": patch
---

Added Story Aeneid chain.
28 changes: 28 additions & 0 deletions src/chains/definitions/storyAeneid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { defineChain } from '../../utils/chain/defineChain.js'

export const storyAeneid = /*#__PURE__*/ defineChain({
id: 1315,
name: 'Story Aeneid',
network: 'story-aeneid',
nativeCurrency: {
decimals: 18,
name: 'IP',
symbol: 'IP',
},
rpcUrls: {
default: { http: ['https://aeneid.storyrpc.io'] },
},
blockExplorers: {
default: {
name: 'Story Aeneid Explorer',
url: 'https://aeneid.storyscan.xyz',
},
},
contracts: {
multicall3: {
address: '0xca11bde05977b3631167028862be2a173976ca11',
blockCreated: 1792,
},
},
testnet: true,
})
3 changes: 3 additions & 0 deletions src/chains/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,10 @@ export { sophonTestnet } from './definitions/sophonTestnet.js'
export { spicy } from './definitions/spicy.js'
export { step } from './definitions/step.js'
export { story } from './definitions/story.js'
export { storyAeneid } from './definitions/storyAeneid.js'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the storyOdyssey and storyTestnet be removed? I believe this generates some confusion. The only testnet described currently in the docs is Aeneid - https://docs.story.foundation/docs/aeneid

Copy link
Contributor Author

@rasplarry rasplarry Feb 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understood storyOdyssey and storyTestnet are deprecated.
I added Aeneid because my app needs it, which means I’m not from Story.
I just saw that a previously closed (not merged) PR marked them as deprecated..
I’m not sure if I can remove them, so should I wait for the foundation to add the chain?

Copy link

@ppedziwiatr ppedziwiatr Feb 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to do the same (i.e. add a PR with the Aeneid testnet), but I've noticed your PR ;)

I just belive that "by the way" the old testnets could be removed (to reduce the confusion among the users) - the Odyssey scanner does not even work anymore - https://odyssey.storyscan.xyz/

I can ask someone from the Story team for confirmation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you ask someone then?!
I'll remove it if it's confirmed. Thank you!

Copy link
Contributor Author

@rasplarry rasplarry Feb 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I just added the @deprecated mark, as the PR I mentioned above did before

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing chains is a breaking change. They will be removed in the next major version.

/** @deprecated Use `storyAeneid` instead. */
export { storyOdyssey } from './definitions/storyOdyssey.js'
/** @deprecated Use `storyAeneid` instead. */
export { storyTestnet } from './definitions/storyTestnet.js'
export { stratis } from './definitions/stratis.js'
export { superlumio } from './definitions/superlumio.js'
Expand Down