Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up a few unit tests #742

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Speed up a few unit tests #742

merged 2 commits into from
Mar 13, 2024

Conversation

crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Mar 4, 2024 •
edited
Loading

Description

Follow up of #739 (comment). Those tests are no longer the slowest ones.

Testing Details

None needed.

  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@crazytonyli crazytonyli requested a review from mokagio March 4, 2024 20:18
mokagio
mokagio approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@mokagio mokagio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those tests are no longer the slowest ones.

image
👍

@crazytonyli crazytonyli merged commit 8c91fc0 into trunk Mar 13, 2024
9 checks passed
@crazytonyli crazytonyli deleted the remove-file-after-uploaded branch March 13, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokagio mokagio mokagio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crazytonyli @mokagio