Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up a few unit tests #742

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Speed up a few unit tests #742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd67da3
Speed up large file creation
crazytonyli Mar 4, 2024
ffa160d
Use smaller files in upload tests
crazytonyli Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions WordPressKitTests/Utilities/URLSessionHelperTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,9 @@ class URLSessionHelperTests: XCTestCase {
HTTPStubsResponse(data: "success".data(using: .utf8)!, statusCode: 200, headers: nil)
}

// Create a large file which will be uploaded
let file = try self.createLargeFile(megaBytes: 100)
// Create a large file which will be uploaded. The file size needs to be larger than the hardcoded threshold of
// creating a temporary file for upload.
let file = try self.createLargeFile(megaBytes: 30)
defer {
try? FileManager.default.removeItem(at: file)
}
Expand Down Expand Up @@ -290,8 +291,9 @@ class URLSessionHelperTests: XCTestCase {
HTTPStubsResponse(error: URLError(.networkConnectionLost))
}

// Create a large file which will be uploaded
let file = try self.createLargeFile(megaBytes: 100)
// Create a large file which will be uploaded. The file size needs to be larger than the hardcoded threshold of
// creating a temporary file for upload.
let file = try self.createLargeFile(megaBytes: 30)
defer {
try? FileManager.default.removeItem(at: file)
}
Expand Down Expand Up @@ -331,16 +333,11 @@ class URLSessionHelperTests: XCTestCase {
}

private func createLargeFile(megaBytes: Int) throws -> URL {
let fileManager = FileManager.default
let file = try fileManager.url(for: .documentDirectory, in: .userDomainMask, appropriateFor: nil, create: true)
let file = try FileManager.default.url(for: .documentDirectory, in: .userDomainMask, appropriateFor: nil, create: true)
.appendingPathComponent("large-file-\(UUID().uuidString).txt")
fileManager.createFile(atPath: file.path, contents: nil)

let handle = try FileHandle(forUpdating: file)
for _ in 0..<megaBytes {
handle.write(Data(repeating: 46, count: 1_000_000))
}
try handle.close()
try Data(repeating: 46, count: 1024 * 1000 * megaBytes).write(to: file)

return file
}

Expand All @@ -349,7 +346,7 @@ class URLSessionHelperTests: XCTestCase {
defer { stream.close() }

var hash = SHA256()
let maxLength = 1024
let maxLength = 50 * 1024
var buffer = [UInt8](repeating: 0, count: maxLength)
while stream.hasBytesAvailable {
let bytes = stream.read(&buffer, maxLength: maxLength)
Expand Down