Merge pull request #1299 from wowsims/feature/update-go-version

Update Go version to 1.23

.github/workflows/deploy.yml

@@ -10,7 +10,7 @@ jobs:
             - name: Install Go
               uses: actions/setup-go@v2
               with:
-                  go-version: 1.21.x
+                  go-version: 1.23.x
 
             - name: Install Protoc
               uses: arduino/setup-protoc@v1

.github/workflows/release.yml

@@ -22,7 +22,7 @@ jobs:
             - name: Install Go
               uses: actions/setup-go@v2
               with:
-                  go-version: 1.21.x
+                  go-version: 1.23.x
 
             - name: Install Protoc
               uses: arduino/setup-protoc@v1

.github/workflows/run_tests.yml

@@ -10,7 +10,7 @@ jobs:
             - name: Install Go
               uses: actions/setup-go@v2
               with:
-                  go-version: 1.21.x
+                  go-version: 1.23.x
 
             - name: Install Protoc
               uses: arduino/setup-protoc@v1

.github/workflows/update_items.yml

@@ -12,7 +12,7 @@ jobs:
             - name: Install Go
               uses: actions/setup-go@v2
               with:
-                  go-version: 1.21.x
+                  go-version: 1.23.x
 
             - name: Install Protoc
               uses: arduino/setup-protoc@v1

Dockerfile

@@ -1,6 +1,6 @@
 # syntax=docker/dockerfile:1
 
-FROM golang:1.21
+FROM golang:1.23
 
 WORKDIR /cata
 

README.md

@@ -20,16 +20,16 @@ Then unzip the downloaded file, then open the unzipped file to open the sim in y
 Alternatively, you can choose from a specific relase on the [Releases](https://github.com/wowsims/cata/releases) page and click the suitable link under "Assets"
 # Local Dev Installation
 
-This project has dependencies on Go >=1.21, protobuf-compiler and the corresponding Go plugins, and node >= 20.
+This project has dependencies on Go >=1.23, protobuf-compiler and the corresponding Go plugins, and node >= 20.
 
 ## Ubuntu
 Do not use apt to install any dependencies, the versions they install are all too old.
 Script below will curl latest versions and install them.
 ```sh
 # Standard Go installation script
-curl -O https://dl.google.com/go/go1.21.1.linux-amd64.tar.gz
+curl -O https://dl.google.com/go/go1.23.4.linux-amd64.tar.gz
 sudo rm -rf /usr/local/go
-sudo tar -C /usr/local -xzf go1.21.1.linux-amd64.tar.gz
+sudo tar -C /usr/local -xzf go1.23.4.linux-amd64.tar.gz
 echo 'export PATH=$PATH:/usr/local/go/bin' >> $HOME/.bashrc
 echo 'export GOPATH=$HOME/go' >> $HOME/.bashrc
 echo 'export PATH=$PATH:$GOPATH/bin' >> $HOME/.bashrc

go.mod

@@ -1,6 +1,6 @@
 module github.com/wowsims/cata
 
-go 1.21
+go 1.23
 
 require (
 	github.com/golang/protobuf v1.5.4

sim/rogue/combat/bandits_guile.go

@@ -43,9 +43,6 @@ func (comRogue *CombatRogue) registerBanditsGuile() {
 				if currentInsightIndex == 2 {
 					currentInsightIndex = -1
 					attackCounter = 0
-				} else if currentInsightIndex == index {
-					// This Insight faded without advancing, reset to no Insight
-					currentInsightIndex = -1
 				}
 			},
 		})