[UI][CORE] Add ability to item swap all gear

[1337LutZ]

When adding this I realised that when swapping items they are never actually "unequipped" (for the sim) since we only check for the existence of spells and disable proc auras for enchants. However for actual on-use items this didn't work because the spell just exists and the Sim keeps thinking it can use it.

Also fixed that the Activate Aura APL would not trigger the actual ICD of the aura.

Update 2024/01/11

• Changed set bonuses to be auras
• Added aura helpers to more easily register effects to a parent Aura
• Refactored the way a ProcMask is assigned by making it dynamic to support Item Swapping ootb
• Added a variety of ItemSwap callbacks for all possible scenarios (atm)

[Polynomix]

Here's some thought : trinkets can only be swapped during prepull/you need to trigger ICDs for trinkets that are procs

If you want to take a look at what i was doing : https://github.com/Polynomix/wowsims-cata/tree/itemswap. Its not so differnt from what you did. The part where i changed the Armor Spec talent is what i was last trying to fix and can be ignored. I probably wont be working on this until my PoE hype dies down.

[1337LutZ]

@Polynomix Thanks so much. I will take your ideas, esp the limitation of not being able to swap non-weapon slots during combat.

[1337LutZ]

@Polynomix I migrated your changes into here.
Removed the weapon swap check since we can just ignore everything else when it's outside of pre-pull. That way you can still swap weapons if you want with other items in the initial prepull. And added a fix for on use trinkets not disabling active auras.

[1337LutZ]

@Polynomix @NerdEgghead I think this is ready for review 👍

[NerdEgghead]

Thought we'd be done for sure this time, but found another scenario that might be broken and needs investigation :(

[NerdEgghead]

I'm now also questioning whether this will behave correctly as well. In the reverse scenario where you swap from a gear set with an on-use trinket to a pre-pull set without any, I think this code would allow the APL to activate the unequipped on-use trinket from the main set even after the swap, since no callback was registered for it.

[1337LutZ]

nope, corect.

if !swap.CanRegisterItemCallback(itemID, slots) {
    return
}

This will check both equips, however doesn't the code only register items part of your equip regardless? 🤔 Thus making this check obsolete?

[NerdEgghead]

If the issue I pointed out with missing possible callbacks for unequipped items is real, then a potential solution would be

if !swap.IsValidSwap(swapSet) && isReset {
    swap.runAllCallbacks()
}

if !swap.IsEnabled() || !swap.IsValidSwap(swapSet) {
    return
}