Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI][CORE] Add ability to item swap all gear #1253

Open
wants to merge 155 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 143 commits
Commits
Show all changes
155 commits
Select commit Hold shift + click to select a range
ec8f55a
Add ability to item swap trinkets
1337LutZ Dec 7, 2024
f22aed1
Fix typo
1337LutZ Dec 7, 2024
c2b01dd
Progress PR merge Polynomix
1337LutZ Dec 8, 2024
9d1a40a
Add full prepull equipment
1337LutZ Dec 9, 2024
54e577d
Remove cast condition logic
1337LutZ Dec 9, 2024
094b070
Fix swap triggering GCD outside combat
1337LutZ Dec 10, 2024
14903dc
Add initialize check for initial flags
1337LutZ Dec 10, 2024
0135729
Fix resetting
1337LutZ Dec 10, 2024
01050d5
Fix item desync
1337LutZ Dec 10, 2024
dd37eed
Remove logs
1337LutZ Dec 10, 2024
1b07f39
Fix reset GCD check
1337LutZ Dec 11, 2024
afbbc60
PR feedback
1337LutZ Dec 11, 2024
ca93e29
Call ICD call to Activate Aura APL
1337LutZ Dec 11, 2024
1ea188d
Fix (num) Buff stat aura APL
1337LutZ Dec 12, 2024
f886ec4
Fix procs
1337LutZ Dec 12, 2024
4ba2e42
Merge branch 'feature/add-trinket-swapping'
1337LutZ Dec 12, 2024
12e88af
Update results
1337LutZ Dec 12, 2024
619656f
Merge branch 'master' into feature/add-trinket-swapping
1337LutZ Dec 12, 2024
87b147b
Missed enchant aura ICD
1337LutZ Dec 12, 2024
257a363
Fix missing trinket procs
1337LutZ Dec 12, 2024
8368bad
Add item swap presets
1337LutZ Dec 12, 2024
3c07949
Fix compile error
1337LutZ Dec 12, 2024
add4008
Add item swap to tests
1337LutZ Dec 12, 2024
9121d90
Update tests
1337LutZ Dec 12, 2024
32d0e9f
Remove Shaman bonus intellect/spellpower settings
1337LutZ Dec 13, 2024
4652e16
Add Fury item swap
1337LutZ Dec 13, 2024
cf80bef
Add Warlock - item sets and update APL
1337LutZ Dec 13, 2024
ce89393
Fix Armor spec logging & faulty item CD trigger when not swapping
1337LutZ Dec 13, 2024
71eca5d
Update tests
1337LutZ Dec 13, 2024
7782ae5
Merge branch 'master' into feature/add-trinket-swapping
1337LutZ Dec 15, 2024
9d2495b
Merge branch 'master' into feature/add-trinket-swapping
1337LutZ Dec 16, 2024
dc53ed1
PR feedback #1
1337LutZ Dec 16, 2024
69281e2
PR Feedback #2 - create enchant proc stat bonus effect helper(s)
1337LutZ Dec 16, 2024
e8caedb
Add IsEnabled check to early return
1337LutZ Dec 16, 2024
8e3dfff
Uncomment ICD check
1337LutZ Dec 16, 2024
e5692c9
Merge branch 'master' into feature/add-trinket-swapping
1337LutZ Dec 17, 2024
86c1718
PR Feedback #3
1337LutZ Dec 17, 2024
9cff836
Fix multithreading issue by reverting slots logic
1337LutZ Dec 17, 2024
9c7bd22
Optimize slots looping
1337LutZ Dec 17, 2024
f4067be
Add back slot loop and sort to fix MT issue
1337LutZ Dec 17, 2024
e816e5b
Remove Armor Spec on expire
1337LutZ Dec 17, 2024
6ab37b8
Merge branch 'master' into feature/add-trinket-swapping
1337LutZ Dec 17, 2024
e5d717d
Fix item swap set bonuses & add swg for shaman
1337LutZ Dec 18, 2024
3b6b6d8
Add Multiply attack speed
1337LutZ Dec 18, 2024
4917bcf
Simplify trinketprocbuffs check
1337LutZ Dec 18, 2024
7ee5a76
Remove redundant Flag check
1337LutZ Dec 18, 2024
66b2890
Migrate WOTLK enchants
1337LutZ Dec 18, 2024
0640950
Fix extending CDs on equip swaps
1337LutZ Dec 18, 2024
23a1d9a
Migrate shaman to set bonus helpers
1337LutZ Dec 18, 2024
cdcad57
Add SetToSortedSlice helper for item_swaps
1337LutZ Dec 18, 2024
159f6e9
Add setName to ItemSet Apply Effect
1337LutZ Dec 18, 2024
c434f20
Migrate DK Set Bonuses
1337LutZ Dec 18, 2024
6bb4ddf
Migrate Druid set bonuses & ignite-like set bonuses
1337LutZ Dec 19, 2024
6ba0a2f
WIP: Refactor to set bonus aura
1337LutZ Dec 20, 2024
8833606
WIP set bonus aura refactor
1337LutZ Dec 20, 2024
1b36516
WIP - set bonus aura update
1337LutZ Dec 20, 2024
2158a2b
Adjust item swap PPM handling
1337LutZ Dec 21, 2024
b33a82e
Remove unused check
1337LutZ Dec 21, 2024
9066f28
Rename default procmask functions
1337LutZ Dec 21, 2024
bcedbc8
Fix cast function matcher
1337LutZ Dec 21, 2024
277ced9
Refacor ppm effect helpers
1337LutZ Dec 23, 2024
70912c4
Merge branch 'master' into feature/add-trinket-swapping
1337LutZ Dec 23, 2024
ced524b
Merge branch 'master' into feature/add-trinket-swapping
1337LutZ Dec 31, 2024
95bffaa
Merge branch 'master' into feature/add-trinket-swapping
1337LutZ Jan 3, 2025
a3e6d66
Merge branch 'master' into feature/add-trinket-swapping
1337LutZ Jan 4, 2025
d15571f
Refactor EnchantProcStatBonus to use ProcStatBonus factory
1337LutZ Jan 4, 2025
5df4292
PR Feedback
1337LutZ Jan 6, 2025
0b97123
Change stat bonus helpers to aura helpers
1337LutZ Jan 6, 2025
7705220
Add swap helper for PVP gloves
1337LutZ Jan 6, 2025
0b2e184
PR feedback - Redundant code
1337LutZ Jan 6, 2025
f0cb149
Merge branch 'master' into feature/add-trinket-swapping
1337LutZ Jan 6, 2025
9466cf3
Remove old TBC unsued code
1337LutZ Jan 6, 2025
ddd6151
PR Feedback - Add default itemset slots override
1337LutZ Jan 6, 2025
2d42959
Fix itemset slots check
1337LutZ Jan 6, 2025
f47fbb8
Fix Hunter T11 bonus
1337LutZ Jan 6, 2025
4bf6e14
Fix old hunter set bonus callback
1337LutZ Jan 6, 2025
0eedf47
Update Hunter tests
1337LutZ Jan 6, 2025
2007ec7
Add SpellMod type Custom
1337LutZ Jan 6, 2025
3979f1c
Rename ItemSwap PPM Effects
1337LutZ Jan 6, 2025
85e0133
Remove redundant extra cast conditions
1337LutZ Jan 6, 2025
1d9eae4
Add stop ranged until
1337LutZ Jan 6, 2025
16f4208
Merge branch 'master' into feature/add-trinket-swapping
NerdEgghead Jan 7, 2025
6f2105a
Keep Energy and Focus tick randomized during reset actions.
NerdEgghead Jan 7, 2025
33179bc
Cleanup PPM Effects & add Enchant Proc / Proc effects instead
1337LutZ Jan 7, 2025
d6b2d0e
Remove redundant init checks
1337LutZ Jan 7, 2025
e7ca46c
Merge branch 'feature/add-trinket-swapping' of https://github.com/wow…
1337LutZ Jan 7, 2025
b2a69bd
Refactor PPM to DPM to allow for dyanmic weapon procs
1337LutZ Jan 7, 2025
100ef14
Merge branch 'master' into feature/add-trinket-swapping
NerdEgghead Jan 8, 2025
41c72cc
Change the weapon and trinket slot aliases to functions in order to
NerdEgghead Jan 8, 2025
cd3b522
Add missing trinket
1337LutZ Jan 8, 2025
fd1fe47
Merge branch 'feature/add-trinket-swapping' of https://github.com/wow…
1337LutZ Jan 8, 2025
98956ee
PR Feedback
1337LutZ Jan 8, 2025
7a73411
PR Feedback - minor item sets cleanup
1337LutZ Jan 8, 2025
a0d4327
Convert missed spellmod
1337LutZ Jan 8, 2025
258db3d
Change Warlock T13 2P to SpellMods
1337LutZ Jan 8, 2025
cf7b51d
Migrate some manual stacking auras to helper
1337LutZ Jan 8, 2025
bd710cf
Optimise item set logic
1337LutZ Jan 9, 2025
32fb4fb
Merge branch 'master' into feature/add-trinket-swapping
1337LutZ Jan 9, 2025
8fa0248
Merge branch 'feature/spell-mod-additions' into feature/add-trinket-s…
1337LutZ Jan 9, 2025
846ef94
Refactor set bonuses to use buff duration spell mods
1337LutZ Jan 9, 2025
1d0772a
Fix tidefury bonus 2p
1337LutZ Jan 9, 2025
19f81ce
Add default Swap set for ret
1337LutZ Jan 9, 2025
a543f73
Remove spellmod keyvalue usage
1337LutZ Jan 9, 2025
5dace3d
Performance optimisations
1337LutZ Jan 9, 2025
841b29f
Merge branch 'master' into feature/add-trinket-swapping
NerdEgghead Jan 10, 2025
a35633e
Update tests after performance optimizations commit
NerdEgghead Jan 10, 2025
9258138
Added Elemental Item Swap presets
1337LutZ Jan 10, 2025
c48061a
Update tests
1337LutZ Jan 10, 2025
0c33740
Merge branch 'feature/add-trinket-swapping' of https://github.com/wow…
1337LutZ Jan 10, 2025
0234d28
Update tests
1337LutZ Jan 10, 2025
ea5e5cd
PR Feedback
1337LutZ Jan 10, 2025
0799b4b
Remove commented code
1337LutZ Jan 10, 2025
e5a4d8c
Fix crusader enchant registration
1337LutZ Jan 10, 2025
fce2792
Refactor Armor Spec application
1337LutZ Jan 10, 2025
f48017e
Remove redundant CalcStatChanges
1337LutZ Jan 10, 2025
af4b1e5
Merge branch 'master' into feature/add-trinket-swapping
1337LutZ Jan 10, 2025
8830fae
Add missing Ele P4 WIP
1337LutZ Jan 10, 2025
206be1f
Merge branch 'fix/warlock-p3' into feature/add-trinket-swapping
1337LutZ Jan 11, 2025
a583b31
Merge branch 'master' into feature/add-trinket-swapping
NerdEgghead Jan 12, 2025
e16fb89
Remove now-unused Slots field from ProcStatBonusEffect and
NerdEgghead Jan 12, 2025
ea0ba0e
Minor code cleanup
NerdEgghead Jan 12, 2025
a8349c2
Merge branch 'master' into feature/add-trinket-swapping
NerdEgghead Jan 12, 2025
2e8f67b
Merge branch 'master' into feature/add-trinket-swapping
NerdEgghead Jan 12, 2025
a00b03c
Merge branch 'master' into feature/add-trinket-swapping
NerdEgghead Jan 12, 2025
fa51113
PR Optimisation
1337LutZ Jan 12, 2025
f7a4174
Fix Hunter item set bug
1337LutZ Jan 12, 2025
7141ef4
Fix T13 4P spellmask
1337LutZ Jan 12, 2025
95ca83f
Merge branch 'feature/add-trinket-swapping' of https://github.com/wow…
1337LutZ Jan 12, 2025
7128452
Tweak Item Swap UI style & add DW check to Slam
1337LutZ Jan 12, 2025
0857ae2
Update item swap slot loop and OH swapping
1337LutZ Jan 12, 2025
b350bf6
Remove redudant swapItem 2H logic and fix UI weapon combo result
1337LutZ Jan 12, 2025
781a99e
Merge branch 'master' into feature/add-trinket-swapping
NerdEgghead Jan 13, 2025
a0e9033
Revert Black Magic and remove unused trigger aura prop
1337LutZ Jan 13, 2025
e60fa3f
Fix wrong item slot lookup
1337LutZ Jan 13, 2025
4ccc495
Unify AA UpdateMeleeOHSwing inside EnableMeleeSwing
1337LutZ Jan 13, 2025
b1187cc
Item set optimisations
1337LutZ Jan 13, 2025
3b0c22b
Merge branch 'feature/add-trinket-swapping' of https://github.com/wow…
1337LutZ Jan 13, 2025
ad926af
Remove console log
1337LutZ Jan 13, 2025
2c5e586
Item Swap code optimisations
1337LutZ Jan 13, 2025
068a250
Update Warlock item swap gearset
1337LutZ Jan 13, 2025
11ebb6f
Add Item Swap bonus stats
1337LutZ Jan 13, 2025
ceb4d85
Fix Warlock P3 gear change
1337LutZ Jan 13, 2025
9a7fb2f
Fix Warlock P3 gear change
1337LutZ Jan 13, 2025
c3b3502
Add reset check for iterations
1337LutZ Jan 14, 2025
3433dee
Add missing item swap registrations
1337LutZ Jan 14, 2025
4e95cef
Update Bryntroll rng seed results
1337LutZ Jan 14, 2025
a01163d
Add DTR OnExpire to flush spell queue
1337LutZ Jan 14, 2025
cd51e4d
Add load settings ignoreUnknownFields prop
1337LutZ Jan 14, 2025
e6a880e
Fix prepull melee swings
1337LutZ Jan 14, 2025
532083f
Add Item Swap slots to Arms Sim
1337LutZ Jan 14, 2025
df90fb3
Update Elemental item swap
1337LutZ Jan 14, 2025
dbace7a
Fix gems in Ele P4 set
1337LutZ Jan 14, 2025
c2ca86e
Merge branch 'master' into feature/add-trinket-swapping
NerdEgghead Jan 15, 2025
8ff9eaa
Set proc ICD to NeverExpire when not equipped
1337LutZ Jan 15, 2025
ec72b64
Merge branch 'feature/add-trinket-swapping' of https://github.com/wow…
1337LutZ Jan 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions proto/common.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1037,9 +1037,11 @@ message CustomSpell {
}

message ItemSwap {
ItemSpec mh_item = 1;
ItemSpec oh_item = 2;
ItemSpec ranged_item = 3;
ItemSpec mh_item = 1 [deprecated=true];
ItemSpec oh_item = 2 [deprecated=true];
ItemSpec ranged_item = 3 [deprecated=true];
repeated ItemSpec items = 4;
1337LutZ marked this conversation as resolved.
Show resolved Hide resolved
UnitStats prepull_bonus_stats = 5;
}

message Duration {
Expand Down
4 changes: 2 additions & 2 deletions proto/shaman.proto
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,9 @@ message ShamanTotems {
bool use_fire_elemental = 12;

// Bonus spell power for fire elemental snapshotting.
int32 bonus_spellpower = 13;
int32 bonus_spellpower = 13 [deprecated=true]; // No longer used in favor of Item Swapping
// Bonus intellect for fire elemental snapshotting.
int32 bonus_intellect = 15;
int32 bonus_intellect = 15 [deprecated=true]; // No longer used in favor of Item Swapping

// Snapshot fire elemental using Tier 10 4 set bonus.
bool enh_tier_ten_bonus = 14;
1337LutZ marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
5 changes: 3 additions & 2 deletions proto/warlock.proto
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,9 @@ message WarlockOptions {

Summon summon = 1;
bool detonate_seed = 2;
int32 prepull_mastery = 3;
int32 prepull_post_snapshot_mana = 4;
int32 prepull_mastery = 3 [deprecated=true]; // Use Item Swap sets instead
int32 prepull_post_snapshot_mana = 4 [deprecated=true]; // Use Item Swap sets instead
bool use_item_swap_bonus_stats = 5;
}

message AfflictionWarlock {
Expand Down
3 changes: 2 additions & 1 deletion proto/warrior.proto
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ message FuryWarrior {
WarriorOptions class_options = 1;
bool stance_snapshot = 2;
WarriorSyncType sync_type = 3;
int32 prepull_mastery = 4;
int32 prepull_mastery = 4 [deprecated=true]; // Use Item Swap sets instead
bool use_item_swap_bonus_stats = 5;
}
Options options = 1;
}
Expand Down
10 changes: 7 additions & 3 deletions sim/common/cata/damage_procs.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ func init() {
School: core.SpellSchoolNature,
MinDmg: 5250,
MaxDmg: 8750,
Outcome: shared.OutcomeMeleeNoBlockDodgeParryCrit,
Flags: core.SpellFlagNoSpellMods | core.SpellFlagIgnoreModifiers | core.SpellFlagNoOnDamageDealt,
Outcome: shared.OutcomeMeleeNoBlockDodgeParryCrit,
Trigger: core.ProcTrigger{
Name: "Darkmoon Card: Hurricane",
ProcMask: core.ProcMaskMeleeOrRanged,
Expand Down Expand Up @@ -74,7 +74,7 @@ func init() {
},
})

core.MakePermanent(core.MakeProcTriggerAura(&character.Unit, core.ProcTrigger{
aura := core.MakePermanent(core.MakeProcTriggerAura(&character.Unit, core.ProcTrigger{
Name: "Electrical Charge Aura",
ActionID: core.ActionID{ItemID: 68925},
Callback: core.CallbackOnSpellHitDealt | core.CallbackOnPeriodicDamageDealt,
Expand All @@ -92,6 +92,8 @@ func init() {
}
},
}))

character.ItemSwap.RegisterProc(68925, aura)
})

core.NewItemEffect(69110, func(agent core.Agent) {
Expand Down Expand Up @@ -124,7 +126,7 @@ func init() {
},
})

core.MakePermanent(core.MakeProcTriggerAura(&character.Unit, core.ProcTrigger{
aura := core.MakePermanent(core.MakeProcTriggerAura(&character.Unit, core.ProcTrigger{
Name: "Electrical Charge Aura",
ActionID: core.ActionID{ItemID: 69110},
Callback: core.CallbackOnSpellHitDealt | core.CallbackOnPeriodicDamageDealt,
Expand All @@ -142,6 +144,8 @@ func init() {
}
},
}))

character.ItemSwap.RegisterProc(69110, aura)
})

}
Loading
Loading