warlock: fix mastery coef for affli 1.63 -> 1.625 #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tooltip incorrectly states that a point of mastery gives 1.63% increased periodic shadow damage, but both dbc values and ingame tests show that value to be 1.625 instead. Tests illustrating the differences ingame: 990 mastery: https://classic.warcraftlogs.com/reports/dMA2t6wLjD7TcCpN#fight=4&type=damage-done&view=events&ability=-172 1000 mastery: https://classic.warcraftlogs.com/reports/dMA2t6wLjD7TcCpN#fight=5&type=damage-done&view=events&ability=-172
Tharre
force-pushed
the
tharre/warlock-fixes
branch
from
894f4d5 to
abafc53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tooltip incorrectly states that a point of mastery gives 1.63% increased periodic shadow damage, but both dbc values and ingame tests show that value to be 1.625 instead.
Tests illustrating the differences ingame:
990 mastery: https://classic.warcraftlogs.com/reports/dMA2t6wLjD7TcCpN#fight=4&type=damage-done&view=events&ability=-172
1000 mastery: https://classic.warcraftlogs.com/reports/dMA2t6wLjD7TcCpN#fight=5&type=damage-done&view=events&ability=-172